Bug 149710 - [GTK] Websites with invalid auth header keep loading forever
Summary: [GTK] Websites with invalid auth header keep loading forever
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2015-10-01 09:38 PDT by Carlos Garcia Campos
Modified: 2015-10-01 10:19 PDT (History)
5 users (show)

See Also:

Patch (9.78 KB, patch)
2015-10-01 09:52 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Fix coding style (9.78 KB, patch)
2015-10-01 09:58 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-10-01 09:38:13 PDT
We don't correctly handle a null realm from the server when retrieving and storing credentials from libsecret. First secret_attributes_build() fails because we pass a null domain, and we pass null attributes to secret_service_search() that returns early on a g_return macro and the callback is never called so the load doesn't continue after the auth challenge. You can try with https://manga.madokami.com/login
Comment 1 Carlos Garcia Campos 2015-10-01 09:52:38 PDT
Created attachment 262265 [details]
Comment 2 WebKit Commit Bot 2015-10-01 09:54:58 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2015-10-01 09:55:05 PDT
Attachment 262265 [details] did not pass style-queue:

ERROR: Source/WebCore/platform/network/gtk/CredentialBackingStore.cpp:52:  Declaration has space between type name and * in const char *realm  [whitespace/declaration] [3]
Total errors found: 1 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Carlos Garcia Campos 2015-10-01 09:58:33 PDT
Created attachment 262267 [details]
Fix coding style
Comment 5 Carlos Garcia Campos 2015-10-01 10:19:04 PDT
Committed r190413: <http://trac.webkit.org/changeset/190413>