Bug 149684 - JetStream timeout should long enough for slow device.
Summary: JetStream timeout should long enough for slow device.
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-30 16:17 PDT by dewei_zhu
Modified: 2022-10-05 15:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.19 KB, patch)
2015-09-30 16:17 PDT, dewei_zhu
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2015-09-30 16:17:31 PDT
JetStream timeout should long enough for slow device.
Comment 1 dewei_zhu 2015-09-30 16:17:50 PDT
Created attachment 262201 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-30 16:18:56 PDT
Attachment 262201 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2015-09-30 16:21:27 PDT
Comment on attachment 262201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262201&action=review

rs=me with comments.

> Tools/ChangeLog:3
> +        Extend JetStream timeout for slow device.

"devices"

> Tools/ChangeLog:7
> +        Extend JetStream timeout to 20 minites.

"minutes"
Comment 4 Ahmad Saleem 2022-10-05 15:24:33 PDT
Already increased to patch time:

https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan#L2

but it landed due to some other patch since when I tried to search with this bug ID, it was not in Commit history on Webkit GitHub.

Marking this as "RESOLVED CONFIGURATION CHANGED", since needed change is already done. Thanks!