Bug 149682 - Web Inspector: Thousands of timers fire after switching to JavaScript and Events timeline
Summary: Web Inspector: Thousands of timers fire after switching to JavaScript and Eve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-30 15:48 PDT by Joseph Pecoraro
Modified: 2015-09-30 17:26 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.42 KB, patch)
2015-09-30 16:05 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-30 15:48:10 PDT
* SUMMARY
Thousands of timers fire after switching to JavaScript and Events timeline.

The UI is slow and frequently unresponsive while interacting with the timeline while these timers fire. For instance scroll synchronization (which uses timers) doesn't get synchronized until all of the previously queued timers are exhausted. That can take 30+ seconds for a large profile.

* STEPS TO REPRODUCE
1. Inspect apple.com
2. Timeline tab
3. Reload
4. Click "JavaScript & Events"
  => try to scroll the data grid after it shows up

* NOTES
- Many many TreeElement onchange events spawned by the "status" of the GeneralTreeElement changing. Seems we don't even need to trigger a treeOutline.onchange for that.
Comment 1 Radar WebKit Bug Importer 2015-09-30 15:48:29 PDT
<rdar://problem/22924064>
Comment 2 Joseph Pecoraro 2015-09-30 16:05:47 PDT
Created attachment 262200 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2015-09-30 16:14:22 PDT
Comment on attachment 262200 [details]
[PATCH] Proposed Fix

Do the close status elements still work? I think I added these to make those close elements work.
Comment 4 Joseph Pecoraro 2015-09-30 16:42:16 PDT
(In reply to comment #3)
> Comment on attachment 262200 [details]
> [PATCH] Proposed Fix
> 
> Do the close status elements still work? I think I added these to make those
> close elements work.

Yes, I tested this a bunch but never encountered an issue. Wherever there is a goto arrow, loading a content view produces a close button to go back. I tested in the overview timeline, network timeline and tab, and JS & Events timeline.
Comment 5 WebKit Commit Bot 2015-09-30 17:26:38 PDT
Comment on attachment 262200 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 262200

Committed r190377: <http://trac.webkit.org/changeset/190377>
Comment 6 WebKit Commit Bot 2015-09-30 17:26:42 PDT
All reviewed patches have been landed.  Closing bug.