Bug 149678 – Add UniqueIDBDatabase object, IDBBackingStore objects, and a database operation thread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Add UniqueIDBDatabase object, IDBBackingStore objects, and a database operation thread

- UniqueIDBDatabase represents a specific IDB database instance that can have multiple connections to it.
- IDBBackingStore is an abstract representation of a unique database's backing store, and has a concrete in-memory implementation for now.
- The database thread exists on IDBServer and is for offloading actual database I/O from the main thread.

[Brady Eidson]

Created attachment 262190 [details]
Patch v1

[Alex Christensen]

Comment on attachment 262190 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=262190&action=review

> Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:152
> +        Locker<Lock> locker(m_databaseThreadCreationLock);

Put a comment saying what this does.

[Brady Eidson]

Created attachment 262205 [details]
Patch v2 for landing

[Brady Eidson]

EFL build failure: https://webkit-queues.webkit.org/results/229258

The build is failing because:

Last 500 characters of output:
server/IDBServer.cpp
In file included from ../../Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:34:0:
../../Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h:38:97: error: 'IDBDatabaseIdentifier' does not name a type
     friend std::unique_ptr<MemoryIDBBackingStore> std::make_unique<MemoryIDBBackingStore>(const IDBDatabaseIdentifier&);

Note the OSX/iOS builds work fine, as IDBDatabaseIdentifier.h is included in that very file and has that definition.

Is this some compiler deficiency on efl/linux?

[Brady Eidson]

Created attachment 262207 [details]
Patch v3 - EWS retry

[WebKit Commit Bot]

Comment on attachment 262207 [details]
Patch v3 - EWS retry

Clearing flags on attachment: 262207

Committed r190379: <http://trac.webkit.org/changeset/190379>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Gyuyoung Kim]

(In reply to comment #6)
> Comment on attachment 262207 [details]
> Patch v3 - EWS retry
> 
> Clearing flags on attachment: 262207
> 
> Committed r190379: <http://trac.webkit.org/changeset/190379>

Fix a build break for EFL and GTK.
https://bugs.webkit.org/show_bug.cgi?id=149693