Bug 149662 - Use modern for-loops in WebCore/html.
Summary: Use modern for-loops in WebCore/html.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-30 05:51 PDT by Hunseop Jeong
Modified: 2015-10-06 06:31 PDT (History)
2 users (show)

See Also:


Attachments
Patch (71.24 KB, patch)
2015-09-30 22:41 PDT, Hunseop Jeong
no flags Details | Formatted Diff | Diff
Patch (71.22 KB, patch)
2015-10-02 00:18 PDT, Hunseop Jeong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-09-30 05:51:18 PDT
Refactor the for-loops using the ranged-for loops and auto keyword in WebCore/html.
Comment 1 Hunseop Jeong 2015-09-30 22:41:38 PDT
Created attachment 262235 [details]
Patch
Comment 2 Darin Adler 2015-10-01 09:24:23 PDT
Comment on attachment 262235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262235&action=review

> Source/WebCore/html/FormController.cpp:270
> +        const FormElementKey& key = element.key;
>          if (!equal(key.type(), "file", 4))
>              continue;

Doesn’t seem to be helpful to put the key into a local variable here.
Comment 3 Hunseop Jeong 2015-10-02 00:18:31 PDT
Created attachment 262320 [details]
Patch
Comment 4 Hunseop Jeong 2015-10-02 00:19:52 PDT
(In reply to comment #2)
> Comment on attachment 262235 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262235&action=review
> 
> > Source/WebCore/html/FormController.cpp:270
> > +        const FormElementKey& key = element.key;
> >          if (!equal(key.type(), "file", 4))
> >              continue;
> 
> Doesn’t seem to be helpful to put the key into a local variable here.

You are right. I removed the local variable.
Comment 5 Hunseop Jeong 2015-10-06 01:06:39 PDT
Darin, ping?

Could you give me the cq+?
Comment 6 WebKit Commit Bot 2015-10-06 06:31:45 PDT
Comment on attachment 262320 [details]
Patch

Clearing flags on attachment: 262320

Committed r190613: <http://trac.webkit.org/changeset/190613>
Comment 7 WebKit Commit Bot 2015-10-06 06:31:48 PDT
All reviewed patches have been landed.  Closing bug.