WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149657
Replace 0 and NULL with nullptr in WebCore/loader.
https://bugs.webkit.org/show_bug.cgi?id=149657
Summary
Replace 0 and NULL with nullptr in WebCore/loader.
Hunseop Jeong
Reported
2015-09-30 03:10:12 PDT
Use the 'nullptr' instead of '0' and 'NULL' in WebCore/loader.
Attachments
Patch
(75.44 KB, patch)
2015-09-30 04:00 PDT
,
Hunseop Jeong
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Hunseop Jeong
Comment 1
2015-09-30 04:00:15 PDT
Created
attachment 262151
[details]
Patch
WebKit Commit Bot
Comment 2
2015-09-30 04:03:03 PDT
Attachment 262151
[details]
did not pass style-queue: ERROR: Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:70: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/loader/FTPDirectoryParser.cpp:1620: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 50 files If any of these errors are false positives, please file a bug against check-webkit-style.
Hunseop Jeong
Comment 3
2015-09-30 04:07:04 PDT
(In reply to
comment #2
)
>
Attachment 262151
[details]
did not pass style-queue: > > > ERROR: Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:70: > Should be indented on a separate line, with the colon or comma first on that > line. [whitespace/indent] [4]
It doesn't look weird.
> ERROR: Source/WebCore/loader/FTPDirectoryParser.cpp:1620: Weird number of > spaces at line-start. Are you using a 4-space indent? [whitespace/indent] > [3]
FTPDirectoryParser.cpp used the 2-space indent.
> Total errors found: 2 in 50 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style.
WebKit Commit Bot
Comment 4
2015-10-20 19:13:14 PDT
Comment on
attachment 262151
[details]
Patch Clearing flags on attachment: 262151 Committed
r191369
: <
http://trac.webkit.org/changeset/191369
>
WebKit Commit Bot
Comment 5
2015-10-20 19:13:17 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug