Bug 149657 - Replace 0 and NULL with nullptr in WebCore/loader.
Summary: Replace 0 and NULL with nullptr in WebCore/loader.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-30 03:10 PDT by Hunseop Jeong
Modified: 2015-10-20 19:13 PDT (History)
2 users (show)

See Also:


Attachments
Patch (75.44 KB, patch)
2015-09-30 04:00 PDT, Hunseop Jeong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-09-30 03:10:12 PDT
Use the 'nullptr' instead of '0' and 'NULL' in WebCore/loader.
Comment 1 Hunseop Jeong 2015-09-30 04:00:15 PDT
Created attachment 262151 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-30 04:03:03 PDT
Attachment 262151 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:70:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/loader/FTPDirectoryParser.cpp:1620:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Hunseop Jeong 2015-09-30 04:07:04 PDT
(In reply to comment #2)
> Attachment 262151 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:70: 
> Should be indented on a separate line, with the colon or comma first on that
> line.  [whitespace/indent] [4]
It doesn't look weird.
> ERROR: Source/WebCore/loader/FTPDirectoryParser.cpp:1620:  Weird number of
> spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent]
> [3]
FTPDirectoryParser.cpp used the 2-space indent.
> Total errors found: 2 in 50 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.
Comment 4 WebKit Commit Bot 2015-10-20 19:13:14 PDT
Comment on attachment 262151 [details]
Patch

Clearing flags on attachment: 262151

Committed r191369: <http://trac.webkit.org/changeset/191369>
Comment 5 WebKit Commit Bot 2015-10-20 19:13:17 PDT
All reviewed patches have been landed.  Closing bug.