Bug 149652 - Make WebKit for iOS Simulator build with the public iOS 9 SDK
Summary: Make WebKit for iOS Simulator build with the public iOS 9 SDK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 9.0
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-29 17:17 PDT by Daniel Bates
Modified: 2015-09-29 18:30 PDT (History)
11 users (show)

See Also:

Attachments
Patch (17.87 KB, patch)
2015-09-29 17:18 PDT, Daniel Bates 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-09-29 17:17:02 PDT 
When using the public iOS 9 SDK, build-webkit --ios-simulator dies with many errors :( We should support building WebKit with the public iOS 9 SDK.
Comment 1 Daniel Bates 2015-09-29 17:18:59 PDT 
Created attachment 262123 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-29 17:21:55 PDT 
Attachment 262123 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cocoa/PthreadSPI.h:33:  pthread_set_fixedpriority_self is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2015-09-29 17:50:21 PDT 
Comment on attachment 262123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262123&action=review

> Source/WebCore/ChangeLog:12
> +        * platform/spi/cocoa/PthreadSPI.h: Added.

The uppercase P is odd, given that the header is pthread.h

> Source/WebCore/platform/spi/cocoa/AVKitSPI.h:77
> +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90000

Is this already inside PLATFORM(IOS)?

> Source/WebCore/platform/spi/cocoa/AVKitSPI.h:104
> +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90000

Ditto.

> Source/WebKit2/Platform/spi/ios/SafariServicesSPI.h:46
> +@interface SFSafariViewController : UIViewController

Isn't SFSafariViewController public?
Comment 4 Daniel Bates 2015-09-29 18:17:58 PDT 
(In reply to comment #3)
> Comment on attachment 262123 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262123&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        * platform/spi/cocoa/PthreadSPI.h: Added.
> 
> The uppercase P is odd, given that the header is pthread.h
> 

Will rename file to pthreadSPI.h.

> > Source/WebCore/platform/spi/cocoa/AVKitSPI.h:77
> > +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90000
> 
> Is this already inside PLATFORM(IOS)?
> 

Yes. We are still interested in building against older iOS SDKs.


> > Source/WebCore/platform/spi/cocoa/AVKitSPI.h:104
> > +#if __IPHONE_OS_VERSION_MIN_REQUIRED < 90000
> 
> Ditto.
> 

See my remark above.

> > Source/WebKit2/Platform/spi/ios/SafariServicesSPI.h:46
> > +@interface SFSafariViewController : UIViewController
> 
> Isn't SFSafariViewController public?

Oops! Will import header <SafariServices/SFSafariViewController.h> to pick up definition of SFSafariViewController.
Comment 5 Daniel Bates 2015-09-29 18:30:48 PDT 
Committed r190336: <http://trac.webkit.org/changeset/190336>