Bug 149651 - Move WebKit2 AsyncTask to WebCore CrossThreadTask
Summary: Move WebKit2 AsyncTask to WebCore CrossThreadTask
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117
  Show dependency tree / graph
 
Reported: 2015-09-29 16:08 PDT by Brady Eidson
Modified: 2015-09-29 23:31 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (65.62 KB, patch)
2015-09-29 16:10 PDT, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
Patch v1 (75.02 KB, patch)
2015-09-29 16:16 PDT, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-09-29 16:08:37 PDT 
Move WebKit2 AsyncTask to WebCore CrossThreadTask

1 - It'll be needed in WebCore for IndexedDB.
2 - It's really only used for an asynchronous task that enforces cross-thread copying, so that's a better name for it.
Comment 1 Brady Eidson 2015-09-29 16:10:18 PDT 
Created attachment 262117 [details]
Patch v1
Comment 2 Brady Eidson 2015-09-29 16:16:22 PDT 
Created attachment 262118 [details]
Patch v1
Comment 3 WebKit Commit Bot 2015-09-29 16:18:08 PDT 
Attachment 262118 [details] did not pass style-queue:


ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/CrossThreadTask.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/CrossThreadTask.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brady Eidson 2015-09-29 16:29:49 PDT 
https://trac.webkit.org/changeset/190331
Comment 5 Brady Eidson 2015-09-29 17:17:01 PDT 
Followup in https://trac.webkit.org/changeset/190332