Bug 149626 – Use separate style resolver for user agent shadow trees

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Antti Koivisto]

We now support separate style resolvers for shadow trees. Use this mechanism to have a separate per-document style resolver for user agent shadow trees. This isolates user agent shadow trees from author style better and simplifies the style resolver. It also avoids some unnecessary style recalcs.

[Antti Koivisto]

Created attachment 262075 [details]
patch

[Andreas Kling]

Comment on attachment 262075 [details]
patch

r=me

[Darin Adler]

Comment on attachment 262075 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262075&action=review

> Source/WebCore/dom/AuthorStyleSheets.cpp:355
> +        Vector<RefPtr<CSSStyleSheet>> newStyleSheets;
> +        newStyleSheets.appendRange(activeStyleSheets.begin() + firstNewIndex, activeStyleSheets.end());

I think there’s a Vector constructor we can use instead of making an empty vector and then appending.

[Build Bot]

Comment on attachment 262075 [details]
patch

Attachment 262075 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/224063

New failing tests:
svg/custom/non-scaling-stroke.svg
svg/custom/use-css-no-effect-on-shadow-tree.svg
svg/W3C-SVG-1.1-SE/struct-use-11-f.svg
svg/css/width-height-presentation-attribute.svg

[Build Bot]

Created attachment 262077 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 262075 [details]
patch

Attachment 262075 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/224087

New failing tests:
svg/custom/non-scaling-stroke.svg
svg/custom/use-css-no-effect-on-shadow-tree.svg
svg/W3C-SVG-1.1-SE/struct-use-11-f.svg
svg/css/width-height-presentation-attribute.svg

[Build Bot]

Created attachment 262078 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Antti Koivisto]

Created attachment 262154 [details]
patch

[Antti Koivisto]

https://trac.webkit.org/r190347