Bug 149626 - Use separate style resolver for user agent shadow trees
Summary: Use separate style resolver for user agent shadow trees
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-29 08:32 PDT by Antti Koivisto
Modified: 2015-09-30 08:42 PDT (History)
3 users (show)

See Also:

Attachments
patch (31.76 KB, patch)
2015-09-29 09:33 PDT, Antti Koivisto 		kling: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (832.07 KB, application/zip)
2015-09-29 10:31 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (874.50 KB, application/zip)
2015-09-29 10:42 PDT, Build Bot 		no flags Details
patch (33.36 KB, patch)
2015-09-30 06:15 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-09-29 08:32:23 PDT 
We now support separate style resolvers for shadow trees. Use this mechanism to have a separate per-document style resolver for user agent shadow trees. This isolates user agent shadow trees from author style better and simplifies the style resolver. It also avoids some unnecessary style recalcs.
Comment 1 Antti Koivisto 2015-09-29 09:33:43 PDT 
Created attachment 262075 [details]
patch
Comment 2 Andreas Kling 2015-09-29 10:22:50 PDT 
Comment on attachment 262075 [details]
patch

r=me
Comment 3 Darin Adler 2015-09-29 10:24:59 PDT 
Comment on attachment 262075 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262075&action=review

> Source/WebCore/dom/AuthorStyleSheets.cpp:355
> +        Vector<RefPtr<CSSStyleSheet>> newStyleSheets;
> +        newStyleSheets.appendRange(activeStyleSheets.begin() + firstNewIndex, activeStyleSheets.end());

I think there’s a Vector constructor we can use instead of making an empty vector and then appending.
Comment 4 Build Bot 2015-09-29 10:31:01 PDT 
Comment on attachment 262075 [details]
patch

Attachment 262075 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/224063

New failing tests:
svg/custom/non-scaling-stroke.svg
svg/custom/use-css-no-effect-on-shadow-tree.svg
svg/W3C-SVG-1.1-SE/struct-use-11-f.svg
svg/css/width-height-presentation-attribute.svg
Comment 5 Build Bot 2015-09-29 10:31:04 PDT 
Created attachment 262077 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Build Bot 2015-09-29 10:42:02 PDT 
Comment on attachment 262075 [details]
patch

Attachment 262075 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/224087

New failing tests:
svg/custom/non-scaling-stroke.svg
svg/custom/use-css-no-effect-on-shadow-tree.svg
svg/W3C-SVG-1.1-SE/struct-use-11-f.svg
svg/css/width-height-presentation-attribute.svg
Comment 7 Build Bot 2015-09-29 10:42:05 PDT 
Created attachment 262078 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 8 Antti Koivisto 2015-09-30 06:15:36 PDT 
Created attachment 262154 [details]
patch
Comment 9 Antti Koivisto 2015-09-30 08:42:17 PDT 
https://trac.webkit.org/r190347