Bug 149622 – Introduce Symbol type for property type inference

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

Introduce Symbol type for property type inference

[Yusuke Suzuki]

Created attachment 262059 [details]
Patch

WIP, not compiled yet

[Yusuke Suzuki]

For example,

const Red = Symbol("Red");
const Blue = Symbol("Green");

class Apple {
    constructor(color)
    {
        this.color = color;
    }
}

let apple = new Apple(Red);
let greenApple = new Apple(Green);

[Yusuke Suzuki]

Created attachment 262849 [details]
Patch

[Geoffrey Garen]

Comment on attachment 262849 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 262849 [details]
Patch

Clearing flags on attachment: 262849

Committed r190916: <http://trac.webkit.org/changeset/190916>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

There are many JSC tests failures after this patch: <https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/175/steps/jscore-test/logs/stdio>

Could you please take a look?

[Yusuke Suzuki]

(In reply to comment #7)
> There are many JSC tests failures after this patch:
> <https://build.webkit.org/builders/
> Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/175/steps/jscore-
> test/logs/stdio>
> 
> Could you please take a look?

Thanks. I'll check this.

[Yusuke Suzuki]

The symbol structure is not registered even if it is used for InferredType.
Since Symbol / String InferredTypes claim that they don't have any structure, registerInferredType does not register these structures.

I've added register structure for Symbol structure in DFGStructureRegisterationPhase as the same to String structure.
Because,

1. InferredType::structure is only allowed for ObjectWithStructure / ObjectWithStructureOrOther. It seems clear to me that only ObjectWithStructure has structure.
2. Symbol is similar primitive value to String. So handling its structure in similar way to String is nice.

I'll land the patch just adding registerStrucutre(Symbol Structure) in DFGStructureRegisterationPhase.

[Yusuke Suzuki]

Committed r190927: <http://trac.webkit.org/changeset/190927>

[Yusuke Suzuki]

(In reply to comment #7)
> There are many JSC tests failures after this patch:
> <https://build.webkit.org/builders/
> Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/175/steps/jscore-
> test/logs/stdio>
> 
> Could you please take a look?

Fixed :)