Bug 149604 - Build WK1 with CMake on Mac
Summary: Build WK1 with CMake on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-28 14:16 PDT by Alex Christensen
Modified: 2015-09-28 15:09 PDT (History)
1 user (show)

See Also:


Attachments
Patch (17.10 KB, patch)
2015-09-28 14:19 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-09-28 14:16:21 PDT
Build WK1 with CMake on Mac
Comment 1 Alex Christensen 2015-09-28 14:19:31 PDT
Created attachment 262019 [details]
Patch
Comment 2 Chris Dumez 2015-09-28 14:27:33 PDT
Comment on attachment 262019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262019&action=review

rs=me with a suggestion.

> Source/WebCore/PlatformMac.cmake:-653
> -    ${WebCore_NON_SVG_IDL_FILES}

Why can we keep using ${WebCore_NON_SVG_IDL_FILES} instead of duplicating all the IDL names? Could we add list of exceptions (the ones that don't generate .mm files) instead? I would assume it would be much shorter.
Comment 3 Alex Christensen 2015-09-28 15:05:12 PDT
Comment on attachment 262019 [details]
Patch

There are several objc-idls that are not in non-svg-idls and several non-svg-idls that are not objc-idls.  I think we should get rid of the non-svg-idls because there is no non-svg build any more.
Comment 4 WebKit Commit Bot 2015-09-28 15:09:19 PDT
Comment on attachment 262019 [details]
Patch

Clearing flags on attachment: 262019

Committed r190287: <http://trac.webkit.org/changeset/190287>
Comment 5 WebKit Commit Bot 2015-09-28 15:09:23 PDT
All reviewed patches have been landed.  Closing bug.