RESOLVED FIXED 149604
Build WK1 with CMake on Mac 
https://bugs.webkit.org/show_bug.cgi?id=149604
Summary Build WK1 with CMake on Mac
Alex Christensen
Reported Monday, September 28, 2015 10:16:21 PM UTC
Build WK1 with CMake on Mac
Attachments
Patch (17.10 KB, patch)
2015-09-28 14:19 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 Monday, September 28, 2015 10:19:31 PM UTC
Created attachment 262019 [details] Patch
Chris Dumez
Comment 2 Monday, September 28, 2015 10:27:33 PM UTC
Comment on attachment 262019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262019&action=review rs=me with a suggestion. > Source/WebCore/PlatformMac.cmake:-653 > - ${WebCore_NON_SVG_IDL_FILES} Why can we keep using ${WebCore_NON_SVG_IDL_FILES} instead of duplicating all the IDL names? Could we add list of exceptions (the ones that don't generate .mm files) instead? I would assume it would be much shorter.
Alex Christensen
Comment 3 Monday, September 28, 2015 11:05:12 PM UTC
Comment on attachment 262019 [details] Patch There are several objc-idls that are not in non-svg-idls and several non-svg-idls that are not objc-idls. I think we should get rid of the non-svg-idls because there is no non-svg build any more.
WebKit Commit Bot
Comment 4 Monday, September 28, 2015 11:09:19 PM UTC
Comment on attachment 262019 [details] Patch Clearing flags on attachment: 262019 Committed r190287: <http://trac.webkit.org/changeset/190287>
WebKit Commit Bot
Comment 5 Monday, September 28, 2015 11:09:23 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.