Add an IDB Server that can roundtrip a request back to the client This is a critical piece of IDB infrastructure that: -Puts a database client/server divide in place. -Client synchronously sends requests to the server, and asynchronously receives a response back from it. -Introduces a class structure that makes it easy for WebKit2 to add a thin layer to replace the in-process server with an out-of-process server. To allow for the most basic of tests, the "delete database" request is hard coded as always failing with an indeterminate error.
Created attachment 262016 [details] Patch v1
Attachment 262016 [details] did not pass style-queue: ERROR: Source/WebCore/page/Page.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h:49: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h:59: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:72: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 262021 [details] Patch v2 - Style and CMakeList
Attachment 262021 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h:49: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h:59: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 262022 [details] Patch v3
Attachment 262022 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h:49: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h:59: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 262022 [details] Patch v3 View in context: https://bugs.webkit.org/attachment.cgi?id=262022&action=review r=me with these changes. > Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp:31 > +#include "Logging.h" Don't touch this file and don't include it in the ChangeLog. > Source/WebCore/Modules/indexeddb/IDBRequest.h:-33 > -#include "DOMRequestState.h" ditto > Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h:49 > + bool isEmpty() const { stylebot doesn't like { on the same line > Source/WebCore/Modules/indexeddb/shared/IDBRequestIdentifier.h:59 > + bool operator==(const IDBRequestIdentifier& other) const { ditto
https://trac.webkit.org/changeset/190291 But the build is broken after that because of reverting the change to IDBRequest.h! lol Following up.
(In reply to comment #8) > https://trac.webkit.org/changeset/190291 > > But the build is broken after that because of reverting the change to > IDBRequest.h! lol > > Following up. Followup in https://trac.webkit.org/changeset/190295
This broke the Windows build. Alex, you should know better!
Alex just showed me we need to add a missing ForwardingHeader location. I'll check in a fix shortly.
Windows build fix in https://trac.webkit.org/changeset/190298.