WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149602
[Win] Allow Windows to run test-webkitpy without Cygwin
https://bugs.webkit.org/show_bug.cgi?id=149602
Summary
[Win] Allow Windows to run test-webkitpy without Cygwin
Brent Fulgham
Reported
2015-09-28 13:47:17 PDT
Update various Python test infrastructure so that it can be run with native Windows Python, without Cygwin support.
Attachments
Patch
(29.05 KB, patch)
2015-09-28 14:00 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Patch v2 (Remove BOM in updated files)
(28.40 KB, patch)
2015-09-28 14:21 PDT
,
Brent Fulgham
achristensen
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2015-09-28 14:00:46 PDT
Created
attachment 262017
[details]
Patch
WebKit Commit Bot
Comment 2
2015-09-28 14:02:15 PDT
Attachment 262017
[details]
did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/system/path.py:1: at least two spaces before inline comment [pep8/E261] [5] ERROR: Tools/Scripts/webkitpy/port/win.py:1: at least two spaces before inline comment [pep8/E261] [5] ERROR: Tools/Scripts/webkitpy/w3c/test_parser_unittest.py:1: at least two spaces before inline comment [pep8/E261] [5] ERROR: Tools/Scripts/webkitpy/style/checker.py:1: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 4 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 3
2015-09-28 14:21:43 PDT
Created
attachment 262020
[details]
Patch v2 (Remove BOM in updated files)
Alex Christensen
Comment 4
2015-09-28 14:42:07 PDT
Comment on
attachment 262020
[details]
Patch v2 (Remove BOM in updated files) r=me
Brent Fulgham
Comment 5
2015-09-28 15:44:37 PDT
Committed
r190290
: <
http://trac.webkit.org/changeset/190290
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug