Bug 149602 - [Win] Allow Windows to run test-webkitpy without Cygwin
Summary: [Win] Allow Windows to run test-webkitpy without Cygwin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-28 13:47 PDT by Brent Fulgham
Modified: 2015-09-28 15:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch (29.05 KB, patch)
2015-09-28 14:00 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch v2 (Remove BOM in updated files) (28.40 KB, patch)
2015-09-28 14:21 PDT, Brent Fulgham
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-09-28 13:47:17 PDT
Update various Python test infrastructure so that it can be run with native Windows Python, without Cygwin support.
Comment 1 Brent Fulgham 2015-09-28 14:00:46 PDT
Created attachment 262017 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-28 14:02:15 PDT
Attachment 262017 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/system/path.py:1:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/Scripts/webkitpy/port/win.py:1:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/Scripts/webkitpy/w3c/test_parser_unittest.py:1:  at least two spaces before inline comment  [pep8/E261] [5]
ERROR: Tools/Scripts/webkitpy/style/checker.py:1:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2015-09-28 14:21:43 PDT
Created attachment 262020 [details]
Patch v2 (Remove BOM in updated files)
Comment 4 Alex Christensen 2015-09-28 14:42:07 PDT
Comment on attachment 262020 [details]
Patch v2 (Remove BOM in updated files)

r=me
Comment 5 Brent Fulgham 2015-09-28 15:44:37 PDT
Committed r190290: <http://trac.webkit.org/changeset/190290>