Bug 149595 – [WTR] Pixel tests generate the snapshots twice in Web and UI processes

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Garcia Campos]

And the snapshot generated in the web process is actually ignored. This is true for all ports except IOS that only creates the snapshots in the web process.

[Carlos Garcia Campos]

Created attachment 262008 [details]
Patch

[Tim Horton]

Comment on attachment 262008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262008&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:896
> +        // Only IOS needs to generate the snapshot in the web process, all other ports generate

iOS *shouldn't*, we just haven't implemented UI process snapshotting for iOS yet.

> Tools/WebKitTestRunner/TestInvocation.cpp:293
> +            dumpPixelsAndCompareWithExpected(m_pixelResult.get(), m_repaintRects.get(), TestInvocation::SnapshotResultType::WebContents);

no curly braces

> Tools/WebKitTestRunner/TestInvocation.cpp:377
> +        if (!m_needsPixelResult) {

This reads pretty weird. "If I don't need a pixel result, extract the pixel result image". Maybe "needs" should be "pending" or some variation of that, since that's what it seems to be (we set it to false when we get a snapshot).

[Carlos Garcia Campos]

(In reply to comment #2)
> Comment on attachment 262008 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262008&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:896
> > +        // Only IOS needs to generate the snapshot in the web process, all other ports generate
> 
> iOS *shouldn't*, we just haven't implemented UI process snapshotting for iOS
> yet.

Ok, I'll reword it to clarify that.

> > Tools/WebKitTestRunner/TestInvocation.cpp:293
> > +            dumpPixelsAndCompareWithExpected(m_pixelResult.get(), m_repaintRects.get(), TestInvocation::SnapshotResultType::WebContents);
> 
> no curly braces

Ok.

> > Tools/WebKitTestRunner/TestInvocation.cpp:377
> > +        if (!m_needsPixelResult) {
> 
> This reads pretty weird. "If I don't need a pixel result, extract the pixel
> result image". Maybe "needs" should be "pending" or some variation of that,
> since that's what it seems to be (we set it to false when we get a snapshot).

Agree, pending sounds better. Thanks

[Carlos Garcia Campos]

Committed r190304: <http://trac.webkit.org/changeset/190304>