Bug 149582 - GCThread machinery should be release-only
Summary: GCThread machinery should be release-only
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-26 13:04 PDT by Filip Pizlo
Modified: 2015-10-03 15:51 PDT (History)
3 users (show)

See Also:


Attachments
the patch (3.59 KB, patch)
2015-09-26 13:05 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (3.60 KB, patch)
2015-09-26 13:07 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (3.62 KB, patch)
2015-09-26 13:10 PDT, Filip Pizlo
mitz: review+
Details | Formatted Diff | Diff
patch for landing (2.40 KB, patch)
2015-09-26 13:22 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
patch for landing (2.70 KB, patch)
2015-09-26 13:30 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-09-26 13:04:29 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2015-09-26 13:05:56 PDT
Created attachment 261973 [details]
the patch
Comment 2 Filip Pizlo 2015-09-26 13:07:33 PDT
Created attachment 261974 [details]
the patch
Comment 3 Filip Pizlo 2015-09-26 13:10:54 PDT
Created attachment 261975 [details]
the patch
Comment 4 mitz 2015-09-26 13:17:32 PDT
Comment on attachment 261975 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261975&action=review

> Source/WTF/wtf/MainThread.h:71
> +inline bool isMainThreadOrGCThread() { return true; }

Since isMainThreadOrGCThread() is only used in assertions and this version is useless, can you just omit it altogether in the ASSERT_DISABLED case?
Comment 5 Filip Pizlo 2015-09-26 13:20:03 PDT
(In reply to comment #4)
> Comment on attachment 261975 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261975&action=review
> 
> > Source/WTF/wtf/MainThread.h:71
> > +inline bool isMainThreadOrGCThread() { return true; }
> 
> Since isMainThreadOrGCThread() is only used in assertions and this version
> is useless, can you just omit it altogether in the ASSERT_DISABLED case?

Yeah, that's better!  I'll try that.
Comment 6 Filip Pizlo 2015-09-26 13:22:24 PDT
Created attachment 261976 [details]
patch for landing
Comment 7 Filip Pizlo 2015-09-26 13:30:35 PDT
Created attachment 261977 [details]
patch for landing
Comment 8 Filip Pizlo 2015-10-03 15:51:29 PDT
Meh, we don't need this.