Bug 149577 – [iOS WK2] Add viewport tests and fix runUIScript() timing issues

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

[iOS WK2] Add viewport tests and fix runUIScript() timing issues

[Simon Fraser (smfr)]

Created attachment 261954 [details]
Patch

[WebKit Commit Bot]

Attachment 261954 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:56:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:209:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6087:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1062:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 261954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261954&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:2475
> +        callback(error != WebKit::CallbackBase::Error::None ? toAPI(API::Error::create().ptr()) : 0, context);

nullptr

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3122
> +- (void)_doAfterNextPresentationUpdate:(void (^)(void))updateBlock

Why is this iOS specific?

> Tools/WebKitTestRunner/TestInvocation.h:80
> +        WebKit::WKRetainPtr<WKStringRef> scriptString;

Do you really need the WebKit::

[Simon Fraser (smfr)]

https://trac.webkit.org/r190260