Bug 149577 - [iOS WK2] Add viewport tests and fix runUIScript() timing issues
Summary: [iOS WK2] Add viewport tests and fix runUIScript() timing issues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-25 16:32 PDT by Simon Fraser (smfr)
Modified: 2015-09-25 17:18 PDT (History)
4 users (show)

See Also:

Attachments
Patch (25.66 KB, patch)
2015-09-25 16:38 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-09-25 16:32:48 PDT 
[iOS WK2] Add viewport tests and fix runUIScript() timing issues
Comment 1 Simon Fraser (smfr) 2015-09-25 16:38:12 PDT 
Created attachment 261954 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-25 16:41:22 PDT 
Attachment 261954 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:56:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:209:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6087:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1062:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2015-09-25 16:42:02 PDT 
Comment on attachment 261954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261954&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:2475
> +        callback(error != WebKit::CallbackBase::Error::None ? toAPI(API::Error::create().ptr()) : 0, context);

nullptr

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3122
> +- (void)_doAfterNextPresentationUpdate:(void (^)(void))updateBlock

Why is this iOS specific?

> Tools/WebKitTestRunner/TestInvocation.h:80
> +        WebKit::WKRetainPtr<WKStringRef> scriptString;

Do you really need the WebKit::
Comment 4 Simon Fraser (smfr) 2015-09-25 17:18:23 PDT 
https://trac.webkit.org/r190260