RESOLVED FIXED 149571
[Mac] USE_INTERNAL_SDK is used undefined in tools projects 
https://bugs.webkit.org/show_bug.cgi?id=149571
Summary [Mac] USE_INTERNAL_SDK is used undefined in tools projects
Alexey Proskuryakov
Reported 2015-09-25 14:47:48 PDT
USE_INTERNAL_SDK is never defined - these projects only have HAVE_INTERNAL_SDK defined. As a result, we get a mismatch of SDKs and toolchains within the same project.
Attachments
proposed patch (10.60 KB, patch)
2015-09-25 14:50 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (10.61 KB, patch)
2015-09-25 14:51 PDT, Alexey Proskuryakov 		mitz: review+
DetailsFormatted DiffDiff
patch for landing (9.33 KB, patch)
2015-09-25 16:18 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-09-25 14:50:44 PDT
Created attachment 261941 [details] proposed patch
Alexey Proskuryakov
Comment 2 2015-09-25 14:51:39 PDT
Created attachment 261942 [details] proposed patch Fixed the bug title.
mitz
Comment 3 2015-09-25 14:55:16 PDT
Comment on attachment 261942 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=261942&action=review Seems OK except for the MinBrowser project changes. > Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:-360 > CODE_SIGN_ENTITLEMENTS = MiniBrowser.entitlements; > - CODE_SIGN_IDENTITY = ""; These lines are gone in TOT. > Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:-369 > CODE_SIGN_ENTITLEMENTS = MiniBrowser.entitlements; > - CODE_SIGN_IDENTITY = ""; These too. > Tools/MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:375 > + CODE_SIGN_IDENTITY = "Safari Engineering"; This doesn’t make sense, and will probably break the build.
Alexey Proskuryakov
Comment 4 2015-09-25 16:18:20 PDT
Created attachment 261953 [details] patch for landing Sorry, the MiniBrowser changes were not meant to be part of the patch.
WebKit Commit Bot
Comment 5 2015-09-25 19:30:18 PDT
Comment on attachment 261953 [details] patch for landing Clearing flags on attachment: 261953 Committed r190263: <http://trac.webkit.org/changeset/190263>
WebKit Commit Bot
Comment 6 2015-09-25 19:30:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.