Bug 149558 - PassRefPtr<> to RefPtr<> conversion in legacy IndexedDB code
Summary: PassRefPtr<> to RefPtr<> conversion in legacy IndexedDB code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117
  Show dependency tree / graph
 
Reported: 2015-09-25 12:20 PDT by Brady Eidson
Modified: 2015-09-25 12:47 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (85.28 KB, patch)
2015-09-25 12:24 PDT, Brady Eidson 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-09-25 12:20:59 PDT 
PassRefPtr<> to RefPtr<> conversion in legacy IndexedDB code

As I fill in IDB interfaces in the modern IDB implementation, I'd rather not be dealing with PassRefPtr at all.
Comment 1 Brady Eidson 2015-09-25 12:24:08 PDT 
Created attachment 261932 [details]
Patch v1
Comment 2 WebKit Commit Bot 2015-09-25 12:25:51 PDT 
Attachment 261932 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBObjectStore.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBFactory.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBDatabaseError.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursor.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/LegacyObjectStore.h:41:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/LegacyCursor.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBAny.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBDatabase.h:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 8 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2015-09-25 12:47:30 PDT 
https://trac.webkit.org/changeset/190250