Bug 149544 – Make custom properties store the parser value list for variable resolution

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Refactor custom property parsing so that we hold the actual CSSParserValueList of parsed terms, functions and operators. This will allow us to iterate directly over the already-parsed terms, functions and operators when we do variable resolution.

[Dave Hyatt]

Created attachment 261904 [details]
Patch

[WebKit Commit Bot]

Attachment 261904 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSCustomPropertyValue.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 261905 [details]
Patch

[Dave Hyatt]

Created attachment 261906 [details]
Patch

[Dean Jackson]

Comment on attachment 261906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261906&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2122
> +    Node* styledNode = this->styledNode();
> +    if (!styledNode)
> +        return emptyString();
> +
> +    RefPtr<RenderStyle> style = computeRenderStyleForProperty(styledNode, m_pseudoElementSpecifier, CSSPropertyCustom);
> +    if (!style || !style->hasCustomProperty(propertyName))
> +        return emptyString();
> +
> +    return style->getCustomPropertyValue(propertyName)->cssText();

Can't all this use customPropertyValue?

Something like

RefPtr<CSSValue> propertyValue = this->customPropertyValue(propertyName);
return propertyValue ? propertyValue->cssText() : emptyString();

[Dave Hyatt]

Landed in r190231.

[Radar WebKit Bug Importer]

<rdar://problem/23771248>