Bug 149543 - Find hole drawn at subframe's 0x0 when a subframe find match is not rendered
Summary: Find hole drawn at subframe's 0x0 when a subframe find match is not rendered
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-24 15:06 PDT by Tim Horton
Modified: 2015-09-25 09:15 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2015-09-24 15:06 PDT, Tim Horton 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-09-24 15:06:11 PDT 
Find hole drawn at subframe's 0x0 when a subframe find match is not rendered
Comment 1 Tim Horton 2015-09-24 15:06:41 PDT 
Created attachment 261898 [details]
Patch
Comment 2 Tim Horton 2015-09-24 16:04:51 PDT 
http://trac.webkit.org/changeset/190228
Comment 3 Darin Adler 2015-09-25 09:15:24 PDT 
Comment on attachment 261898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261898&action=review

> Source/WebKit2/WebProcess/WebPage/FindController.cpp:419
>          for (Vector<IntRect>::iterator it = frameRects.begin(), end = frameRects.end(); it != end; ++it) {
>              it->intersect(visibleRect);
> -            it->move(frameOffset.x(), frameOffset.y());
> +
> +            if (it->isEmpty())
> +                continue;
> +
> +            it->moveBy(frameOffset);
>              rects.append(*it);
>          }

Should use a modern for loop.