RESOLVED FIXED 149542
Remove the use of "Immediate" in JIT function names. 
https://bugs.webkit.org/show_bug.cgi?id=149542
Summary Remove the use of "Immediate" in JIT function names.
Mark Lam
Reported 2015-09-24 14:54:54 PDT
We will rename the following: isOperandConstantImmediateDouble => isOperandConstantDouble getOperandConstantImmediateInt => getOperandConstantInt getConstantOperandImmediateInt => getOperandConstantInt emitJumpIfImmediateInteger => emitJumpIfInt emitJumpIfNotImmediateInteger => emitJumpIfNotInt emitJumpIfNotImmediateIntegers => emitJumpIfNotInt emitPatchableJumpIfNotImmediateInteger => emitPatchableJumpIfNotInt emitJumpSlowCaseIfNotImmediateInteger => emitJumpSlowCaseIfNotInt emitJumpSlowCaseIfNotImmediateNumber => emitJumpSlowCaseIfNotNumber emitJumpSlowCaseIfNotImmediateIntegers => emitJumpSlowCaseIfNotInt emitFastArithReTagImmediate => emitTagInt emitTagAsBoolImmediate => emitTagBool isOperandConstantImmediateInt => isOperandConstantInt isOperandConstantImmediateChar => isOperandConstantChar emitJumpIfImmediateNumber => emitJumpIfNumber emitJumpIfNotImmediateNumber => emitJumpIfNotNumber emitFastArithImmToInt - Deleted because this is an empty function. emitFastArithIntToImmNoCheck => emitTagInt emitPutImmediateToCallFrameHeader => emitPutToCallFrameHeader
Attachments
the fix. (67.69 KB, patch)
2015-09-24 15:48 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
fix 2: fixed style issues. (67.68 KB, patch)
2015-09-24 15:55 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-09-24 15:02:49 PDT
One more: emitPutImmediateToCallFrameHeader => emitPutToCallFrameHeader
Mark Lam
Comment 2 2015-09-24 15:48:51 PDT
Created attachment 261899 [details] the fix.
WebKit Commit Bot
Comment 3 2015-09-24 15:51:08 PDT
Attachment 261899 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JIT.h:466: The parameter name "reg" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JSInterfaceJIT.h:68: The parameter name "reg" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JSInterfaceJIT.h:69: The parameter name "reg" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 4 2015-09-24 15:55:01 PDT
Created attachment 261900 [details] fix 2: fixed style issues.
Geoffrey Garen
Comment 5 2015-09-24 16:32:28 PDT
Comment on attachment 261900 [details] fix 2: fixed style issues. r=me
WebKit Commit Bot
Comment 6 2015-09-24 17:17:37 PDT
Comment on attachment 261900 [details] fix 2: fixed style issues. Clearing flags on attachment: 261900 Committed r190230: <http://trac.webkit.org/changeset/190230>
WebKit Commit Bot
Comment 7 2015-09-24 17:17:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.