We will rename the following: isOperandConstantImmediateDouble => isOperandConstantDouble getOperandConstantImmediateInt => getOperandConstantInt getConstantOperandImmediateInt => getOperandConstantInt emitJumpIfImmediateInteger => emitJumpIfInt emitJumpIfNotImmediateInteger => emitJumpIfNotInt emitJumpIfNotImmediateIntegers => emitJumpIfNotInt emitPatchableJumpIfNotImmediateInteger => emitPatchableJumpIfNotInt emitJumpSlowCaseIfNotImmediateInteger => emitJumpSlowCaseIfNotInt emitJumpSlowCaseIfNotImmediateNumber => emitJumpSlowCaseIfNotNumber emitJumpSlowCaseIfNotImmediateIntegers => emitJumpSlowCaseIfNotInt emitFastArithReTagImmediate => emitTagInt emitTagAsBoolImmediate => emitTagBool isOperandConstantImmediateInt => isOperandConstantInt isOperandConstantImmediateChar => isOperandConstantChar emitJumpIfImmediateNumber => emitJumpIfNumber emitJumpIfNotImmediateNumber => emitJumpIfNotNumber emitFastArithImmToInt - Deleted because this is an empty function. emitFastArithIntToImmNoCheck => emitTagInt emitPutImmediateToCallFrameHeader => emitPutToCallFrameHeader
One more: emitPutImmediateToCallFrameHeader => emitPutToCallFrameHeader
Created attachment 261899 [details] the fix.
Attachment 261899 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JIT.h:466: The parameter name "reg" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JSInterfaceJIT.h:68: The parameter name "reg" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JSInterfaceJIT.h:69: The parameter name "reg" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 261900 [details] fix 2: fixed style issues.
Comment on attachment 261900 [details] fix 2: fixed style issues. r=me
Comment on attachment 261900 [details] fix 2: fixed style issues. Clearing flags on attachment: 261900 Committed r190230: <http://trac.webkit.org/changeset/190230>
All reviewed patches have been landed. Closing bug.