Bug 149540 - FTLOSRExitCompiler incorrectly excludes FPR registers in callee saves loop
Summary: FTLOSRExitCompiler incorrectly excludes FPR registers in callee saves loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-24 13:50 PDT by Saam Barati
Modified: 2015-09-25 16:53 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2015-09-25 16:49 PDT, Michael Saboff 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-09-24 13:50:28 PDT 
The first line in the loop "continue"s if "reg.isGPR()" is false.
Later in the loop, we check "reg.isGPR()" and an else clause if it's false.
This else clause is dead code.

We need to decide if we don't need the else clause or if the check at the top of the loop is faulty.
Comment 1 Michael Saboff 2015-09-25 16:49:44 PDT 
Created attachment 261955 [details]
Patch
Comment 2 Saam Barati 2015-09-25 16:50:43 PDT 
Comment on attachment 261955 [details]
Patch

r=me
Comment 3 Michael Saboff 2015-09-25 16:53:00 PDT 
Committed r190258: <http://trac.webkit.org/changeset/190258>