Bug 149539 - Support building for arbitrary architectures
Summary: Support building for arbitrary architectures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-24 13:27 PDT by Daniel Bates
Modified: 2015-09-24 14:39 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2015-09-24 13:29 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (1.90 KB, patch)
2015-09-24 13:37 PDT, Daniel Bates
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-09-24 13:27:03 PDT
Towards setting up OpenSource iOS device or 32-bit simulator builders we need to teach buildbot to pass the architectures associated with a builder to build-webkit.
Comment 1 Daniel Bates 2015-09-24 13:29:31 PDT
Created attachment 261890 [details]
Patch
Comment 2 Daniel Bates 2015-09-24 13:37:49 PDT
Created attachment 261891 [details]
Patch

Updated patch to only pass ARCHS and ONLY_ACTIVE_ARCH to build-webkit when the property architecture is a non-empty string
Comment 3 Alexey Proskuryakov 2015-09-24 14:20:40 PDT
Comment on attachment 261891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261891&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:213
> +            self.setCommand(self.command + ['ARCHS=' + architecture, 'ONLY_ACTIVE_ARCH=NO'])

Will this work for multiple architectures?
Comment 4 Daniel Bates 2015-09-24 14:28:25 PDT
(In reply to comment #3)
> Comment on attachment 261891 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261891&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:213
> > +            self.setCommand(self.command + ['ARCHS=' + architecture, 'ONLY_ACTIVE_ARCH=NO'])
> 
> Will this work for multiple architectures?

It should. According to <http://docs.buildbot.net/current/manual/cfg-buildsteps.html#buildbot.steps.source.buildbot.steps.shell.ShellCommand> when argument command of a ShellCommand is a list of strings then it is "used directly as an argv array".
Comment 5 Daniel Bates 2015-09-24 14:39:58 PDT
Committed r190219: <http://trac.webkit.org/changeset/190219>