Bug 149537 - Web Inspector: JSGlobalRuntimeAgent unintentionally overrides InspectorRuntimeAgent destruction handling
Summary: Web Inspector: JSGlobalRuntimeAgent unintentionally overrides InspectorRuntim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-09-24 13:10 PDT by Joseph Pecoraro
Modified: 2015-09-28 19:20 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.90 KB, patch)
2015-09-24 13:11 PDT, Joseph Pecoraro 		darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For Landing (2.90 KB, patch)
2015-09-28 18:01 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-24 13:10:24 PDT 
* SUMMARY
JSGlobalRuntimeAgent unintentionally overrides InspectorRuntimeAgent destruction handling.

    JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend
      - does nothing, should at least call "super" InspectorRuntimeAgent::willDestroyFrontendAndBackend
Comment 1 Joseph Pecoraro 2015-09-24 13:11:35 PDT 
Created attachment 261887 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-09-25 10:06:25 PDT 
Comment on attachment 261887 [details]
[PATCH] Proposed Fix

Rejecting attachment 261887 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 261887, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 FAILED -- saving rejects to file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj.rej
patching file Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h
patching file Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.cpp
patching file Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/211203
Comment 3 Joseph Pecoraro 2015-09-28 18:01:50 PDT 
Created attachment 262036 [details]
[PATCH] For Landing
Comment 4 WebKit Commit Bot 2015-09-28 18:55:55 PDT 
Comment on attachment 262036 [details]
[PATCH] For Landing

Clearing flags on attachment: 262036

Committed r190301: <http://trac.webkit.org/changeset/190301>