Bug 149524 - [WinCairo] Incorrect position for windowless plugins.
Summary: [WinCairo] Incorrect position for windowless plugins.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-24 07:57 PDT by peavo
Modified: 2015-09-25 12:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2015-09-24 08:00 PDT, peavo 		no flags Details | Formatted Diff | Diff
Patch (3.69 KB, patch)
2015-09-25 06:46 PDT, peavo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-09-24 07:57:45 PDT 
In some cases, windowless plugins have incorrect position on WinCairo. I am seeing this at e.g. https://tv.nrk.no/serie/nyheter/NNFA15092415/24-09-2015
Comment 1 peavo 2015-09-24 08:00:33 PDT 
Created attachment 261869 [details]
Patch
Comment 2 Alex Christensen 2015-09-24 11:14:54 PDT 
Comment on attachment 261869 [details]
Patch

Brent, is this really AppleWin-specific?  I'm not familiar with this code.
Comment 3 peavo 2015-09-24 11:30:15 PDT 
I am seeing this bug with Flash 18. The behavior might be different with other versions/plugins, though ...
Comment 4 peavo 2015-09-25 06:46:38 PDT 
Created attachment 261923 [details]
Patch
Comment 5 peavo 2015-09-25 06:49:08 PDT 
My bad, the device context transformation is correct, the problem is that it is performed in cases where it shouldn't (when the GraphicsContext hdc == nullptr).
Comment 6 Alex Christensen 2015-09-25 11:28:15 PDT 
Comment on attachment 261923 [details]
Patch

Seems good.
Comment 7 peavo 2015-09-25 11:51:48 PDT 
(In reply to comment #6)
> Comment on attachment 261923 [details]
> Patch
> 
> Seems good.

Thanks for reviewing :)
Comment 8 WebKit Commit Bot 2015-09-25 12:14:10 PDT 
Comment on attachment 261923 [details]
Patch

Clearing flags on attachment: 261923

Committed r190249: <http://trac.webkit.org/changeset/190249>
Comment 9 WebKit Commit Bot 2015-09-25 12:14:15 PDT 
All reviewed patches have been landed.  Closing bug.