Bug 149494 - [jhbuild] switch to new upstream usrsctp library
Summary: [jhbuild] switch to new upstream usrsctp library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 145121
  Show dependency tree / graph
 
Reported: 2015-09-23 00:15 PDT by Philippe Normand
Modified: 2015-10-01 03:53 PDT (History)
5 users (show)

See Also:

Attachments
patch (2.52 KB, patch)
2015-09-23 00:28 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
patch (2.43 KB, patch)
2015-09-23 00:29 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (2.54 KB, patch)
2015-09-28 02:36 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2015-09-23 00:15:27 PDT 
The official repo is now at https://github.com/sctplab/usrsctp
Comment 1 Philippe Normand 2015-09-23 00:28:26 PDT 
Created attachment 261802 [details]
patch
Comment 2 Philippe Normand 2015-09-23 00:29:43 PDT 
Created attachment 261803 [details]
patch
Comment 3 Csaba Osztrogonác 2015-09-23 03:06:20 PDT 
Let me check if EFL port is ready for this switch. I'll check it later today.
But I don't think if anybody upstreamed my fixes. (see bug145128 for details)
Comment 4 Csaba Osztrogonác 2015-09-23 09:11:59 PDT 
(In reply to comment #3)
> Let me check if EFL port is ready for this switch. I'll check it later today.
> But I don't think if anybody upstreamed my fixes. (see bug145128 for details)

I created a pull request to upstream the necessary fixes
to be able to build this module with clang too:
https://github.com/sctplab/usrsctp/pull/17
Comment 5 Csaba Osztrogonác 2015-09-24 03:11:30 PDT 
I don't have time for thinking about an ultimate fix to silence
clang warnings in upstream. I only need a buildable WebKit
with buildable dependencies.

If you would like to switch to the official repo, please add my fix
as a jhbuild patch - https://github.com/ossy-szeged/usrsctp/commit/08c0bbf9d6132937ad66c1ef275c195ad60f844e
Comment 6 Csaba Osztrogonác 2015-09-28 02:36:25 PDT 
Created attachment 262004 [details]
Patch

https://github.com/sctplab/usrsctp/commit/078ff3252f73327e0ac11d6fd5eff62011f6646e added --disable-warnings-as-errors configure option, let's bump to this revision and use this new option. Additionally removed md5sum which is unused when hash is present.
Comment 7 Csaba Osztrogonác 2015-10-01 02:59:48 PDT 
ping?
Comment 8 WebKit Commit Bot 2015-10-01 03:53:03 PDT 
Comment on attachment 262004 [details]
Patch

Clearing flags on attachment: 262004

Committed r190400: <http://trac.webkit.org/changeset/190400>
Comment 9 WebKit Commit Bot 2015-10-01 03:53:09 PDT 
All reviewed patches have been landed.  Closing bug.