WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149494
[jhbuild] switch to new upstream usrsctp library
https://bugs.webkit.org/show_bug.cgi?id=149494
Summary
[jhbuild] switch to new upstream usrsctp library
Philippe Normand
Reported
2015-09-23 00:15:27 PDT
The official repo is now at
https://github.com/sctplab/usrsctp
Attachments
patch
(2.52 KB, patch)
2015-09-23 00:28 PDT
,
Philippe Normand
no flags
Details
Formatted Diff
Diff
patch
(2.43 KB, patch)
2015-09-23 00:29 PDT
,
Philippe Normand
no flags
Details
Formatted Diff
Diff
Patch
(2.54 KB, patch)
2015-09-28 02:36 PDT
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2015-09-23 00:28:26 PDT
Created
attachment 261802
[details]
patch
Philippe Normand
Comment 2
2015-09-23 00:29:43 PDT
Created
attachment 261803
[details]
patch
Csaba Osztrogonác
Comment 3
2015-09-23 03:06:20 PDT
Let me check if EFL port is ready for this switch. I'll check it later today. But I don't think if anybody upstreamed my fixes. (see
bug145128
for details)
Csaba Osztrogonác
Comment 4
2015-09-23 09:11:59 PDT
(In reply to
comment #3
)
> Let me check if EFL port is ready for this switch. I'll check it later today. > But I don't think if anybody upstreamed my fixes. (see
bug145128
for details)
I created a pull request to upstream the necessary fixes to be able to build this module with clang too:
https://github.com/sctplab/usrsctp/pull/17
Csaba Osztrogonác
Comment 5
2015-09-24 03:11:30 PDT
I don't have time for thinking about an ultimate fix to silence clang warnings in upstream. I only need a buildable WebKit with buildable dependencies. If you would like to switch to the official repo, please add my fix as a jhbuild patch -
https://github.com/ossy-szeged/usrsctp/commit/08c0bbf9d6132937ad66c1ef275c195ad60f844e
Csaba Osztrogonác
Comment 6
2015-09-28 02:36:25 PDT
Created
attachment 262004
[details]
Patch
https://github.com/sctplab/usrsctp/commit/078ff3252f73327e0ac11d6fd5eff62011f6646e
added --disable-warnings-as-errors configure option, let's bump to this revision and use this new option. Additionally removed md5sum which is unused when hash is present.
Csaba Osztrogonác
Comment 7
2015-10-01 02:59:48 PDT
ping?
WebKit Commit Bot
Comment 8
2015-10-01 03:53:03 PDT
Comment on
attachment 262004
[details]
Patch Clearing flags on attachment: 262004 Committed
r190400
: <
http://trac.webkit.org/changeset/190400
>
WebKit Commit Bot
Comment 9
2015-10-01 03:53:09 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug