Bug 149476 - Range.surroundContents() should check for partially contained non-Text nodes first
Summary: Range.surroundContents() should check for partially contained non-Text nodes ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#dom-rang...
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2015-09-22 14:58 PDT by Chris Dumez
Modified: 2015-09-28 11:41 PDT (History)
7 users (show)

See Also:


Attachments
Patch (55.22 KB, patch)
2015-09-22 15:02 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-09-22 14:58:00 PDT
Range.surroundContents() should check for partially contained non-Text nodes first, before checking the type of the newParent parameter:
https://dom.spec.whatwg.org/#dom-range-surroundcontents (step 1 and 2)

Firefox and Chrome follow the specification.
Comment 1 Chris Dumez 2015-09-22 15:02:51 PDT
Created attachment 261767 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-22 16:15:16 PDT
Comment on attachment 261767 [details]
Patch

Clearing flags on attachment: 261767

Committed r190139: <http://trac.webkit.org/changeset/190139>
Comment 3 WebKit Commit Bot 2015-09-22 16:15:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2015-09-28 11:41:37 PDT
<rdar://problem/22882532>