Bug 149469 - RenderSVGResourceClipper::applyClippingToContext makes an unconditionally unaccelerated ImageBuffer
Summary: RenderSVGResourceClipper::applyClippingToContext makes an unconditionally una...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-22 11:11 PDT by Tim Horton
Modified: 2023-06-14 17:02 PDT (History)
15 users (show)

See Also:


Attachments
Patch (3.40 KB, patch)
2021-10-16 12:46 PDT, Simon Fraser (smfr)
thorton: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-09-22 11:11:47 PDT
The ImageBuffer should inherit the accelerated bit from the context it will eventually be painted into.

However, doing so breaks some tests when run with --accelerated-drawing on, and clearly also breaks these tests in Safari. Needs more investigation (and possibly bugs filed on other components).
Comment 1 Simon Fraser (smfr) 2021-10-16 12:40:09 PDT
The only one I found in LayoutTests/svg was svg/gradients/spreadMethodClose2.svg which looks like a bug with accelerated drawing.
Comment 2 Simon Fraser (smfr) 2021-10-16 12:41:17 PDT
But svg/gradients/spreadMethodClose2.svg has different behavior in Chrome and Firefox (both of which show blues) so it's not clear what's going on.
Comment 3 Simon Fraser (smfr) 2021-10-16 12:46:19 PDT
Created attachment 441501 [details]
Patch
Comment 4 Ahmad Saleem 2022-10-09 06:32:00 PDT
It seems this r+ patch didn't landed and we have FIXME about it as well:

https://github.com/WebKit/WebKit/blob/ce878379210ced398d994217e26519b433761149/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp#L171

Just wanted to update. Thanks!
Comment 5 Ahmad Saleem 2023-06-14 17:02:00 PDT
NOTE - this patch also still work on WebKit ToT (tested locally).