Bug 149449 – Reduce almost uses of PassRefPtr in Webcore/testing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

I fail to remove PassRefPtr in nternals::serializeObject() and Internals::deserializeObject(). I want to remove it in next patch again.

[Gyuyoung Kim]

Created attachment 261728 [details]
Patch

[Gyuyoung Kim]

Created attachment 261743 [details]
Patch

[Darin Adler]

Comment on attachment 261743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261743&action=review

r=me but please don’t land the incorrect change to JSTestOverrideBuiltins.cpp

> Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:220
> -    JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.namedItem(name)));
> +    JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.namedItem(WTF::move(name))));

This is an expected test result for the bindings generator test, not a source file.

To fix this, we need to change the code that generates this file, not change the file itself.

If you land this change as is, it will just cause the test to start failing because this file doesn’t match what the generator generates. The code for this is deep inside the GenerateImplementation function in the file CodeGeneratorJS.pm.

> Source/WebCore/testing/MallocStatistics.h:36
> +    static Ref<MallocStatistics> create() { return adoptRef(*new MallocStatistics()); }

No need for the () after MallocStatistics.

[Gyuyoung Kim]

Created attachment 261824 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 261743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261743&action=review

>> Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:220
>> +    JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.namedItem(WTF::move(name))));
> 
> This is an expected test result for the bindings generator test, not a source file.
> 
> To fix this, we need to change the code that generates this file, not change the file itself.
> 
> If you land this change as is, it will just cause the test to start failing because this file doesn’t match what the generator generates. The code for this is deep inside the GenerateImplementation function in the file CodeGeneratorJS.pm.

I see. I was wrong. I remove WTF::move() in this line. Thanks.

>> Source/WebCore/testing/MallocStatistics.h:36
>> +    static Ref<MallocStatistics> create() { return adoptRef(*new MallocStatistics()); }
> 
> No need for the () after MallocStatistics.

done.

[WebKit Commit Bot]

Comment on attachment 261824 [details]
Patch

Clearing flags on attachment: 261824

Committed r190202: <http://trac.webkit.org/changeset/190202>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.