Bug 149439 - Shadow DOM: Implement display: contents for slots
Summary: Shadow DOM: Implement display: contents for slots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2015-09-21 18:14 PDT by Ryosuke Niwa
Modified: 2016-04-07 03:29 PDT (History)
6 users (show)

See Also:


Attachments
patch (18.71 KB, patch)
2016-04-06 10:12 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (18.72 KB, patch)
2016-04-06 10:45 PDT, Antti Koivisto
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-09-21 18:14:06 PDT
The slot elements should have the default style rule of "display: contents".
Comment 1 Ryosuke Niwa 2015-09-21 18:14:28 PDT
<rdar://problem/22731922>
Comment 2 Antti Koivisto 2016-04-06 10:12:16 PDT
Created attachment 275779 [details]
patch
Comment 3 WebKit Commit Bot 2016-04-06 10:13:33 PDT
Attachment 275779 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:566:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2016-04-06 10:45:30 PDT
Created attachment 275782 [details]
patch
Comment 5 WebKit Commit Bot 2016-04-06 10:47:33 PDT
Attachment 275782 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:566:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Ryosuke Niwa 2016-04-06 15:00:21 PDT
Comment on attachment 275782 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275782&action=review

> Source/WebCore/dom/ElementRareData.h:132
> +    unsigned m_hasDisplayContents : 1;

It's unfortunate that we have to use rare data for this.
It's interesting that we have bit flags about m_childrenAffectedByHover and m_childrenAffectedByLastChildRules
when there are three node flags of a similar stuff:
        ChildrenAffectedByFirstChildRulesFlag = 1 << 25,
        ChildrenAffectedByLastChildRulesFlag = 1 << 26,
        ChildrenAffectedByHoverRulesFlag = 1 << 27,
perhaps we need to re-think about these bit flags...
Comment 7 Antti Koivisto 2016-04-07 02:13:54 PDT
> It's interesting that we have bit flags about m_childrenAffectedByHover and
> m_childrenAffectedByLastChildRules
> when there are three node flags of a similar stuff:
>         ChildrenAffectedByFirstChildRulesFlag = 1 << 25,
>         ChildrenAffectedByLastChildRulesFlag = 1 << 26,
>         ChildrenAffectedByHoverRulesFlag = 1 << 27,
> perhaps we need to re-think about these bit flags...

I think these are assumed to be more common. I'd like to move all style invalidation flags to a separate structure and out from Nodes themselves. They are not hot enough that we couldn't afford hash lookups.
Comment 8 Antti Koivisto 2016-04-07 03:29:55 PDT
https://trac.webkit.org/r199154