Bug 149439 – Shadow DOM: Implement display: contents for slots

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ryosuke Niwa]

The slot elements should have the default style rule of "display: contents".

[Ryosuke Niwa]

<rdar://problem/22731922>

[Antti Koivisto]

Created attachment 275779 [details]
patch

[WebKit Commit Bot]

Attachment 275779 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:566:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 275782 [details]
patch

[WebKit Commit Bot]

Attachment 275782 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:566:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryosuke Niwa]

Comment on attachment 275782 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275782&action=review

> Source/WebCore/dom/ElementRareData.h:132
> +    unsigned m_hasDisplayContents : 1;

It's unfortunate that we have to use rare data for this.
It's interesting that we have bit flags about m_childrenAffectedByHover and m_childrenAffectedByLastChildRules
when there are three node flags of a similar stuff:
        ChildrenAffectedByFirstChildRulesFlag = 1 << 25,
        ChildrenAffectedByLastChildRulesFlag = 1 << 26,
        ChildrenAffectedByHoverRulesFlag = 1 << 27,
perhaps we need to re-think about these bit flags...

[Antti Koivisto]

> It's interesting that we have bit flags about m_childrenAffectedByHover and
> m_childrenAffectedByLastChildRules
> when there are three node flags of a similar stuff:
>         ChildrenAffectedByFirstChildRulesFlag = 1 << 25,
>         ChildrenAffectedByLastChildRulesFlag = 1 << 26,
>         ChildrenAffectedByHoverRulesFlag = 1 << 27,
> perhaps we need to re-think about these bit flags...

I think these are assumed to be more common. I'd like to move all style invalidation flags to a separate structure and out from Nodes themselves. They are not hot enough that we couldn't afford hash lookups.

[Antti Koivisto]

https://trac.webkit.org/r199154