Bug 149415 - REGRESSION (r182648): UIWebView does not set location.hash synchronously
Summary: REGRESSION (r182648): UIWebView does not set location.hash synchronously
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-21 14:01 PDT by Alexey Proskuryakov
Modified: 2015-09-21 20:06 PDT (History)
7 users (show)

See Also:

Attachments
proposed fix (1.60 KB, patch)
2015-09-21 14:07 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
adding a test (3.06 KB, patch)
2015-09-21 18:08 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-09-21 14:01:06 PDT 
<rdar://problem/22169467>
Comment 1 Alexey Proskuryakov 2015-09-21 14:07:14 PDT 
Created attachment 261684 [details]
proposed fix
Comment 2 Darin Adler 2015-09-21 16:33:52 PDT 
Is there some way to regression-test this?
Comment 3 WebKit Commit Bot 2015-09-21 17:21:41 PDT 
Comment on attachment 261684 [details]
proposed fix

Clearing flags on attachment: 261684

Committed r190092: <http://trac.webkit.org/changeset/190092>
Comment 4 WebKit Commit Bot 2015-09-21 17:21:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2015-09-21 17:40:39 PDT 
I'm looking into what's going on with a test. There is already one that should cover this, but it doesn't fail for some reason, still not sure why.
Comment 6 Alexey Proskuryakov 2015-09-21 17:51:23 PDT 
It's because the bug would only occur when processing a user gesture.
Comment 7 Alexey Proskuryakov 2015-09-21 18:07:52 PDT 
EventSender is not implemented on iOS for WebKit2, but it is for WebKit1, which happens to be what we need.
Comment 8 Alexey Proskuryakov 2015-09-21 18:08:45 PDT 
Created attachment 261709 [details]
adding a test
Comment 9 WebKit Commit Bot 2015-09-21 20:06:23 PDT 
Comment on attachment 261709 [details]
adding a test

Clearing flags on attachment: 261709

Committed r190100: <http://trac.webkit.org/changeset/190100>
Comment 10 WebKit Commit Bot 2015-09-21 20:06:28 PDT 
All reviewed patches have been landed.  Closing bug.