Bug 149393 - Pass JSC::ExecState to the custom bindings by reference
Summary: Pass JSC::ExecState to the custom bindings by reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-20 18:14 PDT by Chris Dumez
Modified: 2015-09-20 19:42 PDT (History)
3 users (show)

See Also:


Attachments
Patch (216.81 KB, patch)
2015-09-20 18:19 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (222.09 KB, patch)
2015-09-20 18:27 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (222.66 KB, patch)
2015-09-20 18:31 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (238.50 KB, patch)
2015-09-20 18:48 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (238.65 KB, patch)
2015-09-20 19:01 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-09-20 18:14:51 PDT
Pass JSC::ExecState to the custom bindings by reference instead of by pointer as it is expected to be non-null.
Comment 1 Chris Dumez 2015-09-20 18:19:30 PDT
Created attachment 261619 [details]
Patch
Comment 2 Chris Dumez 2015-09-20 18:27:45 PDT
Created attachment 261620 [details]
Patch
Comment 3 Chris Dumez 2015-09-20 18:31:38 PDT
Created attachment 261621 [details]
Patch
Comment 4 Chris Dumez 2015-09-20 18:48:21 PDT
Created attachment 261622 [details]
Patch
Comment 5 Chris Dumez 2015-09-20 19:01:19 PDT
Created attachment 261623 [details]
Patch
Comment 6 Sam Weinig 2015-09-20 19:40:58 PDT
Comment on attachment 261623 [details]
Patch

rs=me
Comment 7 Chris Dumez 2015-09-20 19:42:47 PDT
Comment on attachment 261623 [details]
Patch

Clearing flags on attachment: 261623

Committed r190036: <http://trac.webkit.org/changeset/190036>
Comment 8 Chris Dumez 2015-09-20 19:42:54 PDT
All reviewed patches have been landed.  Closing bug.