Bug 149391 - WebKitTestRunner can leak user content script results between tests
Summary: WebKitTestRunner can leak user content script results between tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2015-09-20 14:13 PDT by Alexey Proskuryakov
Modified: 2015-09-20 17:29 PDT (History)
2 users (show)

See Also:

proposed fix (2.36 KB, patch)
2015-09-20 14:17 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-09-20 14:13:37 PDT
WebKitTestRunner removes user content before starting a new test. But this means that user content scripts run in about:blank that is loaded between tests, and can produce output. They can even install timers that will run when WKTR thinks that it's already running a new test.
Comment 1 Alexey Proskuryakov 2015-09-20 14:14:48 PDT
Steps to reproduce: run these tests in order, in a single process:

Comment 2 Alexey Proskuryakov 2015-09-20 14:17:08 PDT
Created attachment 261613 [details]
proposed fix
Comment 3 WebKit Commit Bot 2015-09-20 17:29:00 PDT
Comment on attachment 261613 [details]
proposed fix

Clearing flags on attachment: 261613

Committed r190035: <http://trac.webkit.org/changeset/190035>
Comment 4 WebKit Commit Bot 2015-09-20 17:29:03 PDT
All reviewed patches have been landed.  Closing bug.