149381 – [MediaStream] Clean up MediaStream private interfaces

Bug 149381 - [MediaStream] Clean up MediaStream private interfaces

Summary: [MediaStream] Clean up MediaStream private interfaces

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Media (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Eric Carlson

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2015-09-19 19:22 PDT by Eric Carlson
Modified:	2015-09-21 13:11 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
Proposed patch. (5.85 MB, text/plain) 2015-09-20 16:24 PDT, Eric Carlson	no flags	Details
Proposed patch. (50.98 KB, patch) 2015-09-20 16:27 PDT, Eric Carlson	no flags	Details \| Formatted Diff \| Diff
Proposed patch. (50.82 KB, patch) 2015-09-21 06:25 PDT, Eric Carlson	buildbot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews100 for mac-mavericks (706.98 KB, application/zip) 2015-09-21 07:12 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (714.46 KB, application/zip) 2015-09-21 07:15 PDT, Build Bot	no flags	Details
Updated patch. (50.13 KB, patch) 2015-09-21 07:23 PDT, Eric Carlson	no flags	Details \| Formatted Diff \| Diff
Another updated patch (51.71 KB, patch) 2015-09-21 08:22 PDT, Eric Carlson	no flags	Details \| Formatted Diff \| Diff
Another updated patch (51.71 KB, patch) 2015-09-21 09:15 PDT, Eric Carlson	no flags	Details \| Formatted Diff \| Diff
Another patch. (51.73 KB, patch) 2015-09-21 10:51 PDT, Eric Carlson	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eric Carlson 2015-09-19 19:22:49 PDT

Clean up MediaStream private interfaces

Comment 1 Radar WebKit Bug Importer 2015-09-20 16:24:08 PDT

<rdar://problem/22775212>

Comment 2 Eric Carlson 2015-09-20 16:24:25 PDT

Created attachment 261617 [details]
Proposed patch.

Comment 3 Eric Carlson 2015-09-20 16:27:22 PDT

Created attachment 261618 [details]
Proposed patch.

Comment 4 Eric Carlson 2015-09-21 06:25:05 PDT

Created attachment 261648 [details]
Proposed patch.

Comment 5 Build Bot 2015-09-21 07:12:15 PDT

Comment on attachment 261648 [details]
Proposed patch.

Attachment 261648 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/193312

New failing tests:
media/video-source-error-no-candidate.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-audio-element/audio_constructor.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/src_reflects_attribute_not_source_elements.html
media/W3C/video/error/error_onerror_called_on_bogus_source.html
http/tests/media/text-served-as-text.html
media/video-src-change.html
media/W3C/audio/error/error_onerror_called_on_bogus_source.html
media/invalid-media-url-crash.html
http/tests/media/pdf-served-as-pdf.html

Comment 6 Build Bot 2015-09-21 07:12:18 PDT

Created attachment 261649 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 7 Build Bot 2015-09-21 07:15:45 PDT

Comment on attachment 261648 [details]
Proposed patch.

Attachment 261648 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/193318

New failing tests:
media/video-source-error-no-candidate.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-audio-element/audio_constructor.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/src_reflects_attribute_not_source_elements.html
http/tests/media/text-served-as-text.html
http/tests/media/pdf-served-as-pdf.html
media/invalid-media-url-crash.html
media/video-src-change.html

Comment 8 Build Bot 2015-09-21 07:15:48 PDT

Created attachment 261650 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

Comment 9 Eric Carlson 2015-09-21 07:23:56 PDT

Created attachment 261651 [details]
Updated patch.

Comment 10 Eric Carlson 2015-09-21 08:22:25 PDT

Created attachment 261657 [details]
Another updated patch

Comment 11 Eric Carlson 2015-09-21 09:15:11 PDT

Created attachment 261660 [details]
Another updated patch

One more attempt at "implementing" RealtimeMediaSourceCenterOwr::createMediaStream.

Comment 12 Eric Carlson 2015-09-21 10:51:29 PDT

Created attachment 261665 [details]
Another patch.

Comment 13 Eric Carlson 2015-09-21 13:11:13 PDT

Committed r190072: https://trac.webkit.org/r190072