Bug 149379 - [GTK] REGRESSION(188031): ASSERTION FAILED: menu
Summary: [GTK] REGRESSION(188031): ASSERTION FAILED: menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-19 18:16 PDT by Michael Catanzaro
Modified: 2015-09-21 00:22 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.26 KB, patch)
2015-09-19 20:26 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-09-19 18:16:56 PDT
r188031 added the following call in WebContextMenuProxyGtk::CancelTracking:

m_menu.setPlatformDescription(nullptr);

But the first line of code in setPlatformDescription is an assert to be sure the parameter isn't null.

Reminder: now that we have debug fission enabled by default, we can start using debug builds instead of release builds for development, and avoid such issues.
Comment 1 Michael Catanzaro 2015-09-19 20:26:35 PDT
Created attachment 261600 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-21 00:22:55 PDT
Comment on attachment 261600 [details]
Patch

Clearing flags on attachment: 261600

Committed r190045: <http://trac.webkit.org/changeset/190045>
Comment 3 WebKit Commit Bot 2015-09-21 00:22:59 PDT
All reviewed patches have been landed.  Closing bug.