Bug 149378 - [CallWith=ScriptState] should pass ExecState to the implementation by reference
Summary: [CallWith=ScriptState] should pass ExecState to the implementation by reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-19 18:02 PDT by Chris Dumez
Modified: 2015-09-20 09:41 PDT (History)
2 users (show)

See Also:

Attachments
Patch (577.38 KB, patch)
2015-09-19 18:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (584.59 KB, patch)
2015-09-19 22:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-09-19 18:02:37 PDT 
[CallWith=ScriptState] should pass ExecState to the implementation by reference instead of pointer, as it is expected to be non-null.
Comment 1 Chris Dumez 2015-09-19 18:06:52 PDT 
Created attachment 261594 [details]
Patch
Comment 2 Chris Dumez 2015-09-19 22:11:38 PDT 
Created attachment 261602 [details]
Patch
Comment 3 Sam Weinig 2015-09-20 09:07:36 PDT 
Comment on attachment 261602 [details]
Patch

rs=me
Comment 4 Chris Dumez 2015-09-20 09:41:18 PDT 
Comment on attachment 261602 [details]
Patch

Clearing flags on attachment: 261602

Committed r190028: <http://trac.webkit.org/changeset/190028>
Comment 5 Chris Dumez 2015-09-20 09:41:24 PDT 
All reviewed patches have been landed.  Closing bug.