Bug 149377 - Turn on threaded scrolling by default in the tests
Summary: Turn on threaded scrolling by default in the tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-19 17:55 PDT by Tim Horton
Modified: 2015-09-21 11:01 PDT (History)
8 users (show)

See Also:

Attachments
Patch (19.65 KB, patch)
2015-09-19 17:56 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (822.03 KB, application/zip)
2015-09-19 18:35 PDT, Build Bot 		no flags Details
Patch (21.66 KB, patch)
2015-09-19 19:13 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (852.89 KB, application/zip)
2015-09-19 19:52 PDT, Build Bot 		no flags Details
Patch (22.36 KB, patch)
2015-09-19 23:11 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-09-19 17:55:19 PDT 
Turn on threaded scrolling by default in the tests
Comment 1 Tim Horton 2015-09-19 17:56:47 PDT 
Created attachment 261593 [details]
Patch
Comment 2 Build Bot 2015-09-19 18:35:12 PDT 
Comment on attachment 261593 [details]
Patch

Attachment 261593 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/188257

New failing tests:
fast/text/combining-character-sequence-vertical.html
fast/text/descent-clip-in-scaled-page.html
fast/text/vertical-quotation-marks.html
Comment 3 Build Bot 2015-09-19 18:35:15 PDT 
Created attachment 261596 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 4 Tim Horton 2015-09-19 18:47:07 PDT 
These failures are all really bizarre text rendering differences that should have nothing at all to do with threaded scrolling (or scrolling at all). But, they DO reproduce in Safari, so these are real bugs. (Myles, do you have any idea what's going on here?).
Comment 5 Tim Horton 2015-09-19 19:13:14 PDT 
Created attachment 261597 [details]
Patch
Comment 6 Alexey Proskuryakov 2015-09-19 19:27:18 PDT 
Comment on attachment 261597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261597&action=review

> LayoutTests/ChangeLog:49
> +        Turn off threaded scrolling in three tests where it shouldn't affect the test result,
> +        but for some reason does.

:-/
Comment 7 Tim Horton 2015-09-19 19:33:51 PDT 
(In reply to comment #6)
> Comment on attachment 261597 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261597&action=review
> 
> > LayoutTests/ChangeLog:49
> > +        Turn off threaded scrolling in three tests where it shouldn't affect the test result,
> > +        but for some reason does.
> 
> :-/

I mean... it's better than having it off for *all* the tests :D

But yes, that needs a bug tracking it.
Comment 8 Build Bot 2015-09-19 19:52:04 PDT 
Comment on attachment 261597 [details]
Patch

Attachment 261597 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/188432

New failing tests:
fast/text/descent-clip-in-scaled-page.html
Comment 9 Build Bot 2015-09-19 19:52:08 PDT 
Created attachment 261598 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 10 Tim Horton 2015-09-19 20:09:36 PDT 
(In reply to comment #8)
> Comment on attachment 261597 [details]
> Patch
> 
> Attachment 261597 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.webkit.org/results/188432
> 
> New failing tests:
> fast/text/descent-clip-in-scaled-page.html

Weird, I marked that one.
Comment 11 Tim Horton 2015-09-19 23:11:31 PDT 
Created attachment 261603 [details]
Patch
Comment 12 Tim Horton 2015-09-21 11:01:03 PDT 
http://trac.webkit.org/changeset/190060