WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149370
Get rid of most custom bindings for Location.idl
https://bugs.webkit.org/show_bug.cgi?id=149370
Summary
Get rid of most custom bindings for Location.idl
Chris Dumez
Reported
2015-09-19 09:22:47 PDT
Get rid of most custom bindings for Location.idl by extending the support for the [CallWith=XXX] IDL extended attribute.
Attachments
Patch
(34.16 KB, patch)
2015-09-19 11:23 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2015-09-19 11:23:30 PDT
Created
attachment 261581
[details]
Patch
Darin Adler
Comment 2
2015-09-19 13:50:18 PDT
Comment on
attachment 261581
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=261581&action=review
I think it’s strange that the extra arguments that give context to the setter come *before* the attribute value itself.
> Source/WebCore/bindings/js/JSDocumentCustom.cpp:68 > +// FIXME: Require support for [PutForward=XXX] Web IDL extended attribute.
I don’t think this is a very clear comment. I think what it means is that setting location isn’t correct until we add support for PutForward to the JavaScript bindings generator and then use it for the location attribute. But if that’s what it means, the wording is not really clear about that.
> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3180 > + push(@callWithArgs, "exec") if $codeGenerator->ExtendedAttributeContains($callWith, "ScriptState");
Sure wish this would pass *exec instead of exec. We should start using the type ExecState& instead of ExecState* in new things we create.
Chris Dumez
Comment 3
2015-09-19 13:53:04 PDT
Comment on
attachment 261581
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=261581&action=review
>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3180 >> + push(@callWithArgs, "exec") if $codeGenerator->ExtendedAttributeContains($callWith, "ScriptState"); > > Sure wish this would pass *exec instead of exec. We should start using the type ExecState& instead of ExecState* in new things we create.
Yes, I can do this in a follow-up.
WebKit Commit Bot
Comment 4
2015-09-19 14:37:27 PDT
Comment on
attachment 261581
[details]
Patch Clearing flags on attachment: 261581 Committed
r190017
: <
http://trac.webkit.org/changeset/190017
>
WebKit Commit Bot
Comment 5
2015-09-19 14:37:32 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 6
2015-09-20 20:51:17 PDT
Follow-up GTK build fixes: <
https://trac.webkit.org/r190038
> <
https://trac.webkit.org/r190039
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug