Bug 149370 - Get rid of most custom bindings for Location.idl
Summary: Get rid of most custom bindings for Location.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-19 09:22 PDT by Chris Dumez
Modified: 2015-09-20 20:51 PDT (History)
6 users (show)

See Also:


Attachments
Patch (34.16 KB, patch)
2015-09-19 11:23 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-09-19 09:22:47 PDT
Get rid of most custom bindings for Location.idl by extending the support for the [CallWith=XXX] IDL extended attribute.
Comment 1 Chris Dumez 2015-09-19 11:23:30 PDT
Created attachment 261581 [details]
Patch
Comment 2 Darin Adler 2015-09-19 13:50:18 PDT
Comment on attachment 261581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261581&action=review

I think it’s strange that the extra arguments that give context to the setter come *before* the attribute value itself.

> Source/WebCore/bindings/js/JSDocumentCustom.cpp:68
> +// FIXME: Require support for [PutForward=XXX] Web IDL extended attribute.

I don’t think this is a very clear comment. I think what it means is that setting location isn’t correct until we add support for PutForward to the JavaScript bindings generator and then use it for the location attribute. But if that’s what it means, the wording is not really clear about that.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3180
> +    push(@callWithArgs, "exec") if $codeGenerator->ExtendedAttributeContains($callWith, "ScriptState");

Sure wish this would pass *exec instead of exec. We should start using the type ExecState& instead of ExecState* in new things we create.
Comment 3 Chris Dumez 2015-09-19 13:53:04 PDT
Comment on attachment 261581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261581&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3180
>> +    push(@callWithArgs, "exec") if $codeGenerator->ExtendedAttributeContains($callWith, "ScriptState");
> 
> Sure wish this would pass *exec instead of exec. We should start using the type ExecState& instead of ExecState* in new things we create.

Yes, I can do this in a follow-up.
Comment 4 WebKit Commit Bot 2015-09-19 14:37:27 PDT
Comment on attachment 261581 [details]
Patch

Clearing flags on attachment: 261581

Committed r190017: <http://trac.webkit.org/changeset/190017>
Comment 5 WebKit Commit Bot 2015-09-19 14:37:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Dumez 2015-09-20 20:51:17 PDT
Follow-up GTK build fixes:
<https://trac.webkit.org/r190038>
<https://trac.webkit.org/r190039>