Bug 149362 - Layout milestones aren't synchronized with UI-side compositing transactions
Summary: Layout milestones aren't synchronized with UI-side compositing transactions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-18 18:15 PDT by Tim Horton
Modified: 2015-09-21 12:03 PDT (History)
5 users (show)

See Also:

Attachments
Patch (24.50 KB, patch)
2015-09-18 18:16 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (24.98 KB, patch)
2015-09-21 11:51 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (25.09 KB, patch)
2015-09-21 11:52 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-09-18 18:15:47 PDT 
Layout milestones aren't synchronized with UI-side compositing transactions
Comment 1 Tim Horton 2015-09-18 18:16:25 PDT 
Created attachment 261550 [details]
Patch
Comment 2 mitz 2015-09-18 19:02:55 PDT 
Comment on attachment 261550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261550&action=review

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:263
> +    WebCore::LayoutMilestones m_newlyReachedLayoutMilestones;

Can this be initializer here…

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:493
> +    , m_newlyReachedLayoutMilestones(0)

…instead of here?

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5041
> +    // Clients should not set userData for this message, and it won't be passed through.
> +    ASSERT(!userData);

Doesn’t make sense to have an assertion about the behavior of client code.

Does make sense to rev the client interface to remove the user data.
Comment 3 Tim Horton 2015-09-18 21:33:32 PDT 
(In reply to comment #2)
> Comment on attachment 261550 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261550&action=review
> 
> > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:263
> > +    WebCore::LayoutMilestones m_newlyReachedLayoutMilestones;
> 
> Can this be initializer here…
> 
> > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:493
> > +    , m_newlyReachedLayoutMilestones(0)
> 
> …instead of here?

Definitely.

> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:5041
> > +    // Clients should not set userData for this message, and it won't be passed through.
> > +    ASSERT(!userData);
> 
> Doesn’t make sense to have an assertion about the behavior of client code.

Hmm, that was an Anders plan. But ok!

> Does make sense to rev the client interface to remove the user data.

OK.
Comment 4 Tim Horton 2015-09-21 11:51:30 PDT 
Created attachment 261669 [details]
Patch
Comment 5 Tim Horton 2015-09-21 11:52:06 PDT 
Created attachment 261671 [details]
Patch
Comment 6 WebKit Commit Bot 2015-09-21 12:03:50 PDT 
Comment on attachment 261671 [details]
Patch

Clearing flags on attachment: 261671

Committed r190064: <http://trac.webkit.org/changeset/190064>
Comment 7 WebKit Commit Bot 2015-09-21 12:03:55 PDT 
All reviewed patches have been landed.  Closing bug.