Bug 149359 - VariableEnvironmentNode should inherit from ParserArenaDeletable because VariableEnvironment's must have their destructors run
Summary: VariableEnvironmentNode should inherit from ParserArenaDeletable because Vari...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-18 16:13 PDT by Saam Barati
Modified: 2015-09-19 08:37 PDT (History)
2 users (show)

See Also:


Attachments
patch (5.42 KB, patch)
2015-09-18 17:02 PDT, Saam Barati
no flags Details | Formatted Diff | Diff
patch (5.45 KB, patch)
2015-09-18 17:04 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-09-18 16:13:52 PDT
We are leaking HashMaps.
Comment 1 Saam Barati 2015-09-18 17:02:19 PDT
Created attachment 261545 [details]
patch
Comment 2 Saam Barati 2015-09-18 17:04:50 PDT
Created attachment 261546 [details]
patch
Comment 3 Andreas Kling 2015-09-19 05:10:16 PDT
Comment on attachment 261546 [details]
patch

Good catch.
r=me
Comment 4 WebKit Commit Bot 2015-09-19 08:37:03 PDT
Comment on attachment 261546 [details]
patch

Clearing flags on attachment: 261546

Committed r190014: <http://trac.webkit.org/changeset/190014>
Comment 5 WebKit Commit Bot 2015-09-19 08:37:06 PDT
All reviewed patches have been landed.  Closing bug.