Bug 149358 - UserMediaClientMock leaks every test run
Summary: UserMediaClientMock leaks every test run
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
Depends on:
Reported: 2015-09-18 16:04 PDT by Eric Carlson
Modified: 2015-09-21 11:05 PDT (History)
2 users (show)

See Also:

Proposed patch. (1.18 KB, patch)
2015-09-18 16:07 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
patch (3.27 KB, patch)
2015-09-20 01:19 PDT, Tim Horton
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-09-18 16:04:16 PDT
UserMediaClientMock leaks every test run
Comment 1 Eric Carlson 2015-09-18 16:07:17 PDT
Created attachment 261539 [details]
Proposed patch.
Comment 2 WebKit Commit Bot 2015-09-18 16:58:00 PDT
Comment on attachment 261539 [details]
Proposed patch.

Clearing flags on attachment: 261539

Committed r190001: <http://trac.webkit.org/changeset/190001>
Comment 3 WebKit Commit Bot 2015-09-18 16:58:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Tim Horton 2015-09-20 00:28:21 PDT
This is still leaking, according to the leaks bot.
Comment 5 Tim Horton 2015-09-20 01:07:25 PDT
https://bugs.webkit.org/show_bug.cgi?id=149358 made it so that we would only make a UserMediaController if we didn't already have one, so subsequent calls to provideUserMediaTo end up just leaking the client.

I think instead of bailing if we already have one, we mean to be replacing it. But also it seems like the memory management surrounding Supplement/friends is quite fragile.
Comment 6 Tim Horton 2015-09-20 01:18:08 PDT
I meant https://bugs.webkit.org/show_bug.cgi?id=130311 in the last comment.
Comment 7 Tim Horton 2015-09-20 01:19:38 PDT
Created attachment 261608 [details]
Comment 8 Tim Horton 2015-09-21 11:05:13 PDT