Bug 149351 - isGitSVNDirectory() returns true when Git is not installed
Summary: isGitSVNDirectory() returns true when Git is not installed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-18 12:47 PDT by Daniel Bates
Modified: 2015-09-18 13:01 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2015-09-18 12:48 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-09-18 12:47:13 PDT
If Git is not installed then VCSUtils::isGitSVNDirectory() will return true for an arbitrary directory.
Comment 1 Daniel Bates 2015-09-18 12:48:47 PDT
Created attachment 261510 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-09-18 12:52:48 PDT
Comment on attachment 261510 [details]
Patch

Looks fine as a short term fix, however doesn't this leave us with an error in console? Ideally, we should build without errors or warnings, so that new important errors don't get hidden in the noise.
Comment 3 Daniel Bates 2015-09-18 12:59:48 PDT
(In reply to comment #2)
> Comment on attachment 261510 [details]
> Patch
> 
> Looks fine as a short term fix, however doesn't this leave us with an error
> in console? 

No, it does not leave an error in the console.
Comment 4 Daniel Bates 2015-09-18 13:01:02 PDT
Comment on attachment 261510 [details]
Patch

Clearing flags on attachment: 261510

Committed r189977: <http://trac.webkit.org/changeset/189977>
Comment 5 Daniel Bates 2015-09-18 13:01:06 PDT
All reviewed patches have been landed.  Closing bug.