Bug 149343 - Eliminate some redundant header inclusions
Summary: Eliminate some redundant header inclusions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-18 04:29 PDT by Emanuele Aina
Modified: 2024-02-25 08:58 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.95 KB, patch)
2015-09-18 04:45 PDT, Emanuele Aina 		no flags Details | Formatted Diff | Diff
Patch (4.07 KB, patch)
2015-09-18 06:31 PDT, Emanuele Aina 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emanuele Aina 2015-09-18 04:29:17 PDT 
While working on bug #146511 and bug #147258 I've noticed some uneeded header inclusions. Patch will follow.
Comment 1 Emanuele Aina 2015-09-18 04:45:35 PDT 
Created attachment 261499 [details]
Patch
Comment 2 Emanuele Aina 2015-09-18 06:31:53 PDT 
Created attachment 261500 [details]
Patch
Comment 3 Ahmad Saleem 2024-02-24 15:59:49 PST 
It seems this r+ patch didn't landed and we still have these headers except the change of 'LayerTreeHostGtk' where the file was removed with this commit:

https://github.com/WebKit/WebKit/commit/9a0bd86b48685a6bc5a2a7729c9d3666aee2f31c

Local build with 'build-webkit --release' work with remaining patch but I don't know if it would have on internal builds. Happy to do PR and give credits to original author.
Comment 4 EWS 2024-02-25 08:57:34 PST 
Committed 275294@main (36e27eaf8bd4): <https://commits.webkit.org/275294@main>

Reviewed commits have been landed. Closing PR #25070 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2024-02-25 08:58:18 PST 
<rdar://problem/123599112>