WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
149343
Eliminate some redundant header inclusions
https://bugs.webkit.org/show_bug.cgi?id=149343
Summary
Eliminate some redundant header inclusions
Emanuele Aina
Reported
2015-09-18 04:29:17 PDT
While working on
bug #146511
and
bug #147258
I've noticed some uneeded header inclusions. Patch will follow.
Attachments
Patch
(3.95 KB, patch)
2015-09-18 04:45 PDT
,
Emanuele Aina
no flags
Details
Formatted Diff
Diff
Patch
(4.07 KB, patch)
2015-09-18 06:31 PDT
,
Emanuele Aina
darin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Emanuele Aina
Comment 1
2015-09-18 04:45:35 PDT
Created
attachment 261499
[details]
Patch
Emanuele Aina
Comment 2
2015-09-18 06:31:53 PDT
Created
attachment 261500
[details]
Patch
Ahmad Saleem
Comment 3
2024-02-24 15:59:49 PST
It seems this r+ patch didn't landed and we still have these headers except the change of 'LayerTreeHostGtk' where the file was removed with this commit:
https://github.com/WebKit/WebKit/commit/9a0bd86b48685a6bc5a2a7729c9d3666aee2f31c
Local build with 'build-webkit --release' work with remaining patch but I don't know if it would have on internal builds. Happy to do PR and give credits to original author.
EWS
Comment 4
2024-02-25 08:57:34 PST
Committed
275294@main
(36e27eaf8bd4): <
https://commits.webkit.org/275294@main
> Reviewed commits have been landed. Closing PR #25070 and removing active labels.
Radar WebKit Bug Importer
Comment 5
2024-02-25 08:58:18 PST
<
rdar://problem/123599112
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug