Bug 149326 – Implement linear memory instructions in WebAssembly

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Sukolsak Sakshuwong]

Implement linear memory instructions in WebAssembly

https://github.com/WebAssembly/design/blob/master/AstSemantics.md#linear-memory

[Sukolsak Sakshuwong]

Created attachment 261477 [details]
Patch

[WebKit Commit Bot]

Attachment 261477 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:288:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:289:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:290:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:291:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:292:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Lam]

Comment on attachment 261477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261477&action=review

> Source/JavaScriptCore/wasm/WASMModuleParser.cpp:99
> +    // FIXME: Remove this limitation.

Drive by comment: please create a bug (so we don't forget to address this) and add the URL to this comment.

[Geoffrey Garen]

Comment on attachment 261477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261477&action=review

r=me

>> Source/JavaScriptCore/wasm/WASMModuleParser.cpp:99
>> +    // FIXME: Remove this limitation.
> 
> Drive by comment: please create a bug (so we don't forget to address this) and add the URL to this comment.

Even better would be to remove this comment, since we don't know yet whether the spec will require us to change or not.

[Sukolsak Sakshuwong]

Created attachment 261523 [details]
remove the FIXME for the ArrayBuffer's length limit

[WebKit Commit Bot]

Attachment 261523 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:288:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:289:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:290:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:291:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:292:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 261523 [details]
remove the FIXME for the ArrayBuffer's length limit

r=me

[WebKit Commit Bot]

Comment on attachment 261523 [details]
remove the FIXME for the ArrayBuffer's length limit

Clearing flags on attachment: 261523

Committed r189993: <http://trac.webkit.org/changeset/189993>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.