Bug 149326 - Implement linear memory instructions in WebAssembly
Summary: Implement linear memory instructions in WebAssembly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 146064
  Show dependency treegraph
 
Reported: 2015-09-17 19:34 PDT by Sukolsak Sakshuwong
Modified: 2015-09-18 16:07 PDT (History)
9 users (show)

See Also:


Attachments
Patch (41.17 KB, patch)
2015-09-17 20:17 PDT, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff
remove the FIXME for the ArrayBuffer's length limit (41.13 KB, patch)
2015-09-18 14:17 PDT, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sukolsak Sakshuwong 2015-09-17 19:34:38 PDT
Implement linear memory instructions in WebAssembly

https://github.com/WebAssembly/design/blob/master/AstSemantics.md#linear-memory
Comment 1 Sukolsak Sakshuwong 2015-09-17 20:17:15 PDT
Created attachment 261477 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-17 20:19:35 PDT
Attachment 261477 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:288:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:289:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:290:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:291:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:292:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2015-09-18 10:27:24 PDT
Comment on attachment 261477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261477&action=review

> Source/JavaScriptCore/wasm/WASMModuleParser.cpp:99
> +    // FIXME: Remove this limitation.

Drive by comment: please create a bug (so we don't forget to address this) and add the URL to this comment.
Comment 4 Geoffrey Garen 2015-09-18 11:02:07 PDT
Comment on attachment 261477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261477&action=review

r=me

>> Source/JavaScriptCore/wasm/WASMModuleParser.cpp:99
>> +    // FIXME: Remove this limitation.
> 
> Drive by comment: please create a bug (so we don't forget to address this) and add the URL to this comment.

Even better would be to remove this comment, since we don't know yet whether the spec will require us to change or not.
Comment 5 Sukolsak Sakshuwong 2015-09-18 14:17:57 PDT
Created attachment 261523 [details]
remove the FIXME for the ArrayBuffer's length limit
Comment 6 WebKit Commit Bot 2015-09-18 14:20:22 PDT
Attachment 261523 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:288:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:289:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:290:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:291:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/wasm/WASMConstants.h:292:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Geoffrey Garen 2015-09-18 15:41:55 PDT
Comment on attachment 261523 [details]
remove the FIXME for the ArrayBuffer's length limit

r=me
Comment 8 WebKit Commit Bot 2015-09-18 16:07:04 PDT
Comment on attachment 261523 [details]
remove the FIXME for the ArrayBuffer's length limit

Clearing flags on attachment: 261523

Committed r189993: <http://trac.webkit.org/changeset/189993>
Comment 9 WebKit Commit Bot 2015-09-18 16:07:09 PDT
All reviewed patches have been landed.  Closing bug.