Bug 149325 - [iOS WK2] WTR fails to set the key window in the UIKit sense
Summary: [iOS WK2] WTR fails to set the key window in the UIKit sense
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-17 18:33 PDT by Simon Fraser (smfr)
Modified: 2018-02-26 11:31 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.57 KB, patch)
2015-09-17 18:39 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (12.33 KB, patch)
2015-09-17 18:43 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (13.04 KB, patch)
2015-09-17 18:50 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (5.98 KB, patch)
2015-09-17 18:55 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-09-17 18:33:53 PDT
[iOS WK2] WTR fails to set the key window in the UIKit sense
Comment 1 Simon Fraser (smfr) 2015-09-17 18:39:19 PDT
Created attachment 261468 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-09-17 18:43:16 PDT
Created attachment 261469 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-09-17 18:50:55 PDT
Created attachment 261471 [details]
Patch
Comment 4 Simon Fraser (smfr) 2015-09-17 18:55:17 PDT
Created attachment 261473 [details]
Patch
Comment 5 Tim Horton 2015-09-17 18:56:45 PDT
Comment on attachment 261473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261473&action=review

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:121
> +    [m_view release];

why are these not retainptrs?
Comment 6 Simon Fraser (smfr) 2015-09-17 18:59:29 PDT
https://trac.webkit.org/r189959
Comment 7 Daniel Bates 2018-02-26 11:31:18 PST
*** Bug 81736 has been marked as a duplicate of this bug. ***