Bug 149323 - Explicitly specify builtin JS files dependency
Summary: Explicitly specify builtin JS files dependency
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-17 18:13 PDT by Yusuke Suzuki
Modified: 2015-09-18 09:38 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.71 KB, patch)
2015-09-17 18:31 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (4.62 KB, patch)
2015-09-17 18:46 PDT, Yusuke Suzuki
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-09-17 18:13:31 PDT
JSCBuiltins.{h,cpp} in CMakeLists.txt just depend on builtins directory.
As a result, even if we modify builtins/*.js code, rebuild does not regenerate JSCBuiltins.{h,cpp}.
It was long-lasting problem.

Now, ModuleLoaderObject.js is updated. And since Windows bot starts using CMake, it fails now.
https://webkit-queues.webkit.org/results/181214
As the same to the cpp sources, let's list up the JS files explicitly in CMakeLists.txt.
Comment 1 Yusuke Suzuki 2015-09-17 18:16:30 PDT
I don't think using GLOB is good for this case.
http://www.cmake.org/cmake/help/v3.3/command/file.html?highlight=glob#file

> Note We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate.
Comment 2 Yusuke Suzuki 2015-09-17 18:31:58 PDT
Created attachment 261467 [details]
Patch
Comment 3 Yusuke Suzuki 2015-09-17 18:36:00 PDT
Comment on attachment 261467 [details]
Patch

Not related to the original problem, I'll add list to DerivedSources.make
Comment 4 Yusuke Suzuki 2015-09-17 18:46:40 PDT
Created attachment 261470 [details]
Patch
Comment 5 Alex Christensen 2015-09-17 22:34:29 PDT
Comment on attachment 261470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261470&action=review

> Source/JavaScriptCore/DerivedSources.make:96
> +JSCBuiltinsSources: \

Do you not have to define this before you use it?  Make is amazing.
Comment 6 Yusuke Suzuki 2015-09-18 09:38:20 PDT
Comment on attachment 261470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261470&action=review

>> Source/JavaScriptCore/DerivedSources.make:96
>> +JSCBuiltinsSources: \
> 
> Do you not have to define this before you use it?  Make is amazing.

Yeah. Make can do for tasks!
Comment 7 Yusuke Suzuki 2015-09-18 09:38:23 PDT
Committed r189968: <http://trac.webkit.org/changeset/189968>