Bug 149323 – Explicitly specify builtin JS files dependency

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

JSCBuiltins.{h,cpp} in CMakeLists.txt just depend on builtins directory.
As a result, even if we modify builtins/*.js code, rebuild does not regenerate JSCBuiltins.{h,cpp}.
It was long-lasting problem.

Now, ModuleLoaderObject.js is updated. And since Windows bot starts using CMake, it fails now.
https://webkit-queues.webkit.org/results/181214
As the same to the cpp sources, let's list up the JS files explicitly in CMakeLists.txt.

[Yusuke Suzuki]

I don't think using GLOB is good for this case.
http://www.cmake.org/cmake/help/v3.3/command/file.html?highlight=glob#file

> Note We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate.

[Yusuke Suzuki]

Created attachment 261467 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 261467 [details]
Patch

Not related to the original problem, I'll add list to DerivedSources.make

[Yusuke Suzuki]

Created attachment 261470 [details]
Patch

[Alex Christensen]

Comment on attachment 261470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261470&action=review

> Source/JavaScriptCore/DerivedSources.make:96
> +JSCBuiltinsSources: \

Do you not have to define this before you use it?  Make is amazing.

[Yusuke Suzuki]

Comment on attachment 261470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261470&action=review

>> Source/JavaScriptCore/DerivedSources.make:96
>> +JSCBuiltinsSources: \
> 
> Do you not have to define this before you use it?  Make is amazing.

Yeah. Make can do for tasks!

[Yusuke Suzuki]

Committed r189968: <http://trac.webkit.org/changeset/189968>