Bug 149318 - Backdrop Filter should not be visible if element has visibility:hidden
Summary: Backdrop Filter should not be visible if element has visibility:hidden
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Reported: 2015-09-17 16:59 PDT by Joseph Pecoraro
Modified: 2016-04-21 18:49 PDT (History)
5 users (show)

See Also:

Patch (12.48 KB, patch)
2016-04-21 18:00 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (14.72 KB, patch)
2016-04-21 18:35 PDT, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-17 16:59:46 PDT
Backdrop Filter should not be visible if element has visibility:hidden.

.back {
    width: 300px;
    height: 150px;
    margin: 100px;
    background: blue;
.top {
    width: 1000px;
    height: 50px;
    position: absolute;
    left: 0;
    top: 150px;
    -webkit-backdrop-filter: blur(50px);
    visibility: hidden;
<div class="back">
    <div class="top"></div>

1. Open test
  => did not expect div with visibility:hidden to still have blur visible
Comment 1 Radar WebKit Bug Importer 2015-09-17 17:01:04 PDT
Comment 2 Brian Ward 2015-12-28 16:43:46 PST
Just wanted to add that if the parent element has visibility:hidden, the child that has the blur will still composit the blur onto the page, even though it is expected that all content within the parent, including the child would be hidden.
Comment 3 Dean Jackson 2016-04-21 18:00:43 PDT
Created attachment 276991 [details]
Comment 4 Simon Fraser (smfr) 2016-04-21 18:21:42 PDT
Comment on attachment 276991 [details]

This needs to fix PlatformCALayerRemote too.
Comment 5 Dean Jackson 2016-04-21 18:35:20 PDT
Created attachment 276995 [details]
Comment 6 Simon Fraser (smfr) 2016-04-21 18:41:21 PDT
Comment on attachment 276995 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=276995&action=review

> LayoutTests/ChangeLog:15
> +        * css3/filters/backdrop/backdrop-with-visibility-hidden-changing-expected.txt: Added.
> +        * css3/filters/backdrop/backdrop-with-visibility-hidden-changing.html: Added.
> +        * css3/filters/backdrop/backdrop-with-visibility-hidden-expected.txt: Added.
> +        * css3/filters/backdrop/backdrop-with-visibility-hidden.html: Added.

Maybe include a ref test?
Comment 7 Dean Jackson 2016-04-21 18:49:17 PDT
Committed r199862: <http://trac.webkit.org/changeset/199862>
Comment 8 Dean Jackson 2016-04-21 18:49:33 PDT
Committed r199862: <http://trac.webkit.org/changeset/199862>