Bug 149307 - Web Inspector: Remove unused canClearBrowserCookies / canClearBrowserCache protocol methods
Summary: Web Inspector: Remove unused canClearBrowserCookies / canClearBrowserCache pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-09-17 15:41 PDT by Joseph Pecoraro
Modified: 2015-09-17 22:06 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (22.99 KB, patch)
2015-09-17 15:46 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-17 15:41:18 PDT 
* SUMMARY
Remove unused canClearBrowserCookies / canClearBrowserCache protocol methods.

They were only used by Chromium, never used by any WebKit ports. Lets just remove them from the protocol.
Also clean up other places where InspectorClient were not being used.
Comment 1 Joseph Pecoraro 2015-09-17 15:46:18 PDT 
Created attachment 261446 [details]
[PATCH] Proposed Fix
Comment 2 BJ Burg 2015-09-17 21:19:06 PDT 
Comment on attachment 261446 [details]
[PATCH] Proposed Fix

r=me

Amazed we still have such dead code.. :{
Comment 3 WebKit Commit Bot 2015-09-17 22:06:36 PDT 
Comment on attachment 261446 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 261446

Committed r189964: <http://trac.webkit.org/changeset/189964>
Comment 4 WebKit Commit Bot 2015-09-17 22:06:40 PDT 
All reviewed patches have been landed.  Closing bug.