Bug 149278 – AX: aria-hidden=false causes video fallback content to be exposed to AX API

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[James Craig]

Created attachment 261411 [details]
test case

AX: aria-hidden=false causes video fallback content to be exposed to AX API

aria-hidden="false" should only affect the node (<div>) and immediate child text nodes. In this case, it is causing a grandchild text node to be exposed.

[Radar WebKit Bug Importer]

<rdar://problem/22744328>

[Nan Wang]

Created attachment 275243 [details]
patch

[chris fleizach]

Comment on attachment 275243 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275243&action=review

> Source/WebCore/ChangeLog:12
> +        No new tests.

should mention the updated test

> Source/WebCore/accessibility/AXObjectCache.cpp:2518
> +            if (testNode->renderer() != nil)

if (!testNode->renderer())

[Nan Wang]

Comment on attachment 275243 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275243&action=review

>> Source/WebCore/accessibility/AXObjectCache.cpp:2518
>> +            if (testNode->renderer() != nil)
> 
> if (!testNode->renderer())

I think you mean if(testNode->renderer()) ?

[Nan Wang]

Created attachment 275244 [details]
patch

review comments

[WebKit Commit Bot]

Comment on attachment 275244 [details]
patch

Clearing flags on attachment: 275244

Committed r198895: <http://trac.webkit.org/changeset/198895>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.