Bug 149278 - AX: aria-hidden=false causes video fallback content to be exposed to AX API
Summary: AX: aria-hidden=false causes video fallback content to be exposed to AX API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Safari 9
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-17 12:46 PDT by James Craig
Modified: 2016-03-31 09:17 PDT (History)
10 users (show)

See Also:


Attachments
test case (177 bytes, text/html)
2015-09-17 12:46 PDT, James Craig
no flags Details
patch (4.08 KB, patch)
2016-03-30 17:36 PDT, Nan Wang
no flags Details | Formatted Diff | Diff
patch (4.14 KB, patch)
2016-03-30 17:49 PDT, Nan Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2015-09-17 12:46:06 PDT
Created attachment 261411 [details]
test case

AX: aria-hidden=false causes video fallback content to be exposed to AX API

aria-hidden="false" should only affect the node (<div>) and immediate child text nodes. In this case, it is causing a grandchild text node to be exposed.
Comment 1 Radar WebKit Bug Importer 2015-09-17 12:46:41 PDT
<rdar://problem/22744328>
Comment 2 Nan Wang 2016-03-30 17:36:35 PDT
Created attachment 275243 [details]
patch
Comment 3 chris fleizach 2016-03-30 17:43:12 PDT
Comment on attachment 275243 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275243&action=review

> Source/WebCore/ChangeLog:12
> +        No new tests.

should mention the updated test

> Source/WebCore/accessibility/AXObjectCache.cpp:2518
> +            if (testNode->renderer() != nil)

if (!testNode->renderer())
Comment 4 Nan Wang 2016-03-30 17:48:21 PDT
Comment on attachment 275243 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275243&action=review

>> Source/WebCore/accessibility/AXObjectCache.cpp:2518
>> +            if (testNode->renderer() != nil)
> 
> if (!testNode->renderer())

I think you mean if(testNode->renderer()) ?
Comment 5 Nan Wang 2016-03-30 17:49:14 PDT
Created attachment 275244 [details]
patch

review comments
Comment 6 WebKit Commit Bot 2016-03-31 09:17:14 PDT
Comment on attachment 275244 [details]
patch

Clearing flags on attachment: 275244

Committed r198895: <http://trac.webkit.org/changeset/198895>
Comment 7 WebKit Commit Bot 2016-03-31 09:17:18 PDT
All reviewed patches have been landed.  Closing bug.