Bug 149276 - Refactor common code between GetCatchHandlerFunctor and UnwindFunctor
Summary: Refactor common code between GetCatchHandlerFunctor and UnwindFunctor
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
Depends on:
Reported: 2015-09-17 12:03 PDT by Saam Barati
Modified: 2015-09-18 18:27 PDT (History)
8 users (show)

See Also:

patch (6.71 KB, patch)
2015-09-17 18:53 PDT, Saam Barati
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-09-17 12:03:44 PDT
There is a lot of duplicate code between them.
We should probably reuse the code, and just add
another field to UnwindFunctor to give it a "search"
mode that doesn't copyCalleeSaves and also unwinds past
VM entry frames.
Comment 1 Saam Barati 2015-09-17 18:27:58 PDT
Change of plans. I'm keeping two separate functors and just
writing a function to be shared between them.
Comment 2 Saam Barati 2015-09-17 18:53:46 PDT
Created attachment 261472 [details]
Comment 3 Mark Lam 2015-09-18 09:31:54 PDT
Comment on attachment 261472 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=261472&action=review

Looks good. r=me

> Source/JavaScriptCore/ChangeLog:3
> +        Abstract some common code between GetCatchHandlerFunctor and UnwindFunctor

Do you mean "Extract" instead of "Abstract"?  Or perhaps "Refactor common code out of Get...".
Comment 4 Saam Barati 2015-09-18 18:27:14 PDT
landed in: